uClibc compatibility #5270
Merged
uClibc compatibility #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidplace7
commented
Nov 7, 2024
| @@ -3,6 +3,7 @@ | |||
| #include "PhoneAPI.h" | |||
| #include "Stream.h" | |||
| #include "concurrency/OSThread.h" | |||
| #include <cstdarg> | |||
There was a problem hiding this comment.
va_list type definition is not included in uClibc by default. Easy fix.
vidplace7
commented
Nov 7, 2024
Comment on lines
+5
to
+6
| build_flags = ${portduino_base.build_flags} -O0 -I variants/portduino | ||
| -I /usr/include |
There was a problem hiding this comment.
I patch (remove) this value in buildroot-meshtastic, so I can use the includes that buildroot stages.
A separate line is just a more stable target for removing. Thanks!
vidplace7
commented
Nov 7, 2024
| @@ -32,6 +32,7 @@ build_flags = | |||
| -Isrc/platform/portduino | |||
| -DRADIOLIB_EEPROM_UNSUPPORTED | |||
| -DPORTDUINO_LINUX_HARDWARE | |||
| -lstdc++fs | |||
There was a problem hiding this comment.
Allows std::filesystem to function on uClibc
Adds compatibility with uclibc, the officially supported toolchain of the luckfox pico
Bringing this over from buildroot-meshtastic
caveman99
force-pushed
the
uclibc-compat
branch
from
29a9a1a to
2adb56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5219
This PR resolves errors when compiling with
uClibc, so that it may be used with buildroot-meshtastic.Notably,
uClibcis the natively supported toolchain for the LuckFox Pico.