Fix sending duplicate packets to PhoneAPI/MQTT #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Nov 11, 2024
fifieldt
approved these changes
Nov 11, 2024
|
@thebentern Just found that in some cases this actually causes it to not send to the PhoneAPI when it actually should. Will try to find a better fix... |
GUVWAF
added a commit
to GUVWAF/Meshtastic-device
that referenced
this pull request
Nov 12, 2024
…)" This reverts commit 40bc04b.
thebentern
pushed a commit
that referenced
this pull request
Nov 12, 2024
|
Thanks for solving. Going test :) |
|
Testing 2.5.13 for duplicate message it's not ok for now. Easy to reproduce for me feel free ask more testing.
|
|
OK I must update the other side also because it can receive twice also |
|
Solved for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally introduced with #5232.
When receiving repeated packets due to dropped ACKs/replies, we should re-do any routing or sending ACK/replies, but we shouldn’t resend it to the PhoneAPI or MQTT.
To check this, I moved the PacketHistory to the Router class (which is needed for #2856 anyway).