Handle repeated packet after potentially canceling previous Tx #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #5315 and part of #5232. Due to #5315, sometimes packets would not be sent to the PhoneAPI/MQTT because
wasSeenRecently()found a packet that was just added by a previous call to that function.Instead of changing
wasSeenRecently()as done in #5232, when receiving a repeated packet (when the original Tx is retransmitting), only after potentially canceling a packet in the TxQueue, we will check if we needed to rebroadcast this packet again, or resend an ACK.