[ci] fix errors about line length in yaml files (Part 4) #6804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Jan 28, 2025
Comment on lines
+9
to
+12
| if: | | ||
| github.event.issue.pull_request && | ||
| contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) && | ||
| startsWith(github.event.comment.body, '/gha run') |
There was a problem hiding this comment.
| @@ -394,6 +414,7 @@ jobs: | |||
| - script: | | |||
| git clean -d -f -x | |||
| displayName: 'Clean source directory' | |||
| # yamllint disable rule:line-length | |||
There was a problem hiding this comment.
Refer to #6758 (comment)
| @@ -63,10 +63,12 @@ jobs: | |||
| submodules: true | |||
| - name: Install packages | |||
| shell: bash | |||
| # yamllint disable rule:line-length | |||
There was a problem hiding this comment.
I wasn't able to make disable-line directive work with multiline string.
StrikerRUS
changed the title
StrikerRUS
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
jameslamb
approved these changes
Jan 28, 2025
Comment on lines
+248
to
+250
| R_LIBS="c('R6', 'data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'RhpcBLASctl', 'testthat')" | ||
| RDscript${{ matrix.r_customization }} \ | ||
| -e "install.packages(${R_LIBS}, repos = 'https://cran.rstudio.com', Ncpus = parallel::detectCores())" |
There was a problem hiding this comment.
I'm ok with this for now now. But I think we should eventually just move all these R package installs into a single CI script like ci/install-r-deps.R, to reduce duplication. Would you support something like that? I can put up a PR if you agree.
There was a problem hiding this comment.
Absolutely, it would be great!
StrikerRUS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR in series of PRs for linting yaml files.
This PR fixes long lines error.
Continuation of #6794.
See #6758 for background and future PRs' content required to fix all errors with the proposed config.
Closed #6758.