-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] fix errors about line length in yaml files (Part 4) #6804
Changes from all commits
4e03776
8c3c3de
1381428
33fc9ac
bb158b8
e92ba4b
b5ca1d1
495b703
955b318
5dceac8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,9 +18,14 @@ jobs: | |
- uses: lee-dohm/[email protected] | ||
with: | ||
closeComment: > | ||
This issue has been automatically closed because it has been awaiting a response for too long. | ||
When you have time to to work with the maintainers to resolve this issue, please post a new comment and it will be re-opened. | ||
If the issue has been locked for editing by the time you return to it, please open a new issue and reference this one. | ||
This issue has been automatically closed | ||
because it has been awaiting a response for too long. | ||
|
||
When you have time to to work with the maintainers to resolve this issue, | ||
please post a new comment and it will be re-opened. | ||
If the issue has been locked for editing by the time you return to it, | ||
please open a new issue and reference this one. | ||
|
||
Thank you for taking the time to improve LightGBM! | ||
daysUntilClose: 30 | ||
responseRequiredLabel: awaiting response | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,10 +63,12 @@ jobs: | |
submodules: true | ||
- name: Install packages | ||
shell: bash | ||
# yamllint disable rule:line-length | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't able to make |
||
run: | | ||
Rscript -e "install.packages(c('R6', 'data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'RhpcBLASctl', 'roxygen2', 'testthat'), repos = 'https://cran.rstudio.com', Ncpus = parallel::detectCores())" | ||
sh build-cran-package.sh || exit 1 | ||
R CMD INSTALL --with-keep.source lightgbm_*.tar.gz || exit 1 | ||
# yamllint enable rule:line-length | ||
- name: Test documentation | ||
shell: bash --noprofile --norc {0} | ||
run: | | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,10 @@ on: | |
|
||
jobs: | ||
triggering-tests: | ||
if: github.event.issue.pull_request && contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) && startsWith(github.event.comment.body, '/gha run') | ||
if: | | ||
github.event.issue.pull_request && | ||
contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) && | ||
startsWith(github.event.comment.body, '/gha run') | ||
Comment on lines
+9
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
runs-on: ubuntu-latest | ||
env: | ||
SECRETS_WORKFLOW: ${{ secrets.WORKFLOW }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,7 +137,12 @@ jobs: | |
filePath: $(Build.SourcesDirectory)/.ci/test.sh | ||
targetType: filePath | ||
- task: PublishBuildArtifacts@1 | ||
condition: and(succeeded(), in(variables['TASK'], 'regular', 'sdist', 'bdist', 'swig'), not(startsWith(variables['Build.SourceBranch'], 'refs/pull/'))) | ||
condition: > | ||
and( | ||
succeeded(), | ||
in(variables['TASK'], 'regular', 'sdist', 'bdist', 'swig'), | ||
not(startsWith(variables['Build.SourceBranch'], 'refs/pull/')) | ||
) | ||
inputs: | ||
pathtoPublish: '$(Build.ArtifactStagingDirectory)' | ||
artifactName: PackageAssets | ||
|
@@ -279,7 +284,12 @@ jobs: | |
/bin/bash $BUILD_DIRECTORY/docker-script.sh | ||
displayName: 'Setup and run tests' | ||
- task: PublishBuildArtifacts@1 | ||
condition: and(succeeded(), in(variables['TASK'], 'bdist'), not(startsWith(variables['Build.SourceBranch'], 'refs/pull/'))) | ||
condition: > | ||
and( | ||
succeeded(), | ||
in(variables['TASK'], 'bdist'), | ||
not(startsWith(variables['Build.SourceBranch'], 'refs/pull/')) | ||
) | ||
inputs: | ||
pathtoPublish: '$(Build.ArtifactStagingDirectory)' | ||
artifactName: PackageAssets | ||
|
@@ -332,7 +342,12 @@ jobs: | |
filePath: $(Build.SourcesDirectory)/.ci/test.sh | ||
targetType: filePath | ||
- task: PublishBuildArtifacts@1 | ||
condition: and(succeeded(), in(variables['TASK'], 'regular', 'bdist', 'swig'), not(startsWith(variables['Build.SourceBranch'], 'refs/pull/'))) | ||
condition: > | ||
and( | ||
succeeded(), | ||
in(variables['TASK'], 'regular', 'bdist', 'swig'), | ||
not(startsWith(variables['Build.SourceBranch'], 'refs/pull/')) | ||
) | ||
inputs: | ||
pathtoPublish: '$(Build.ArtifactStagingDirectory)' | ||
artifactName: PackageAssets | ||
|
@@ -377,7 +392,12 @@ jobs: | |
cmd /c "powershell -ExecutionPolicy Bypass -File %BUILD_SOURCESDIRECTORY%/.ci/test-windows.ps1" | ||
displayName: Test | ||
- task: PublishBuildArtifacts@1 | ||
condition: and(succeeded(), in(variables['TASK'], 'regular', 'bdist', 'swig'), not(startsWith(variables['Build.SourceBranch'], 'refs/pull/'))) | ||
condition: > | ||
and( | ||
succeeded(), | ||
in(variables['TASK'], 'regular', 'bdist', 'swig'), | ||
not(startsWith(variables['Build.SourceBranch'], 'refs/pull/')) | ||
) | ||
inputs: | ||
pathtoPublish: '$(Build.ArtifactStagingDirectory)' | ||
artifactName: PackageAssets | ||
|
@@ -394,6 +414,7 @@ jobs: | |
- script: | | ||
git clean -d -f -x | ||
displayName: 'Clean source directory' | ||
# yamllint disable rule:line-length | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Refer to #6758 (comment) |
||
- script: | | ||
LGB_VER=$(head -n 1 VERSION.txt | sed "s/rc/-/g") | ||
R_LIB_PATH=~/Rlib | ||
|
@@ -402,6 +423,7 @@ jobs: | |
RDscript -e "install.packages(c('R6', 'data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'RhpcBLASctl'), lib = '${R_LIB_PATH}', dependencies = c('Depends', 'Imports', 'LinkingTo'), repos = 'https://cran.rstudio.com', Ncpus = parallel::detectCores())" || exit 1 | ||
sh build-cran-package.sh --r-executable=RD || exit 1 | ||
mv lightgbm_${LGB_VER}.tar.gz $(Build.ArtifactStagingDirectory)/lightgbm-${LGB_VER}-r-cran.tar.gz | ||
# yamllint enable rule:line-length | ||
displayName: 'Build CRAN R-package' | ||
- task: PublishBuildArtifacts@1 | ||
condition: succeeded() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this for now now. But I think we should eventually just move all these R package installs into a single CI script like
ci/install-r-deps.R
, to reduce duplication. Would you support something like that? I can put up a PR if you agree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, it would be great!