Fix flashing RiggedHandMesh #10754
Merged
Fix flashing RiggedHandMesh #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a timing when the hand controller is already tracked and provides a position, though no joint data is available yet. I.e. when you move hands quickly into the HL2 tracking view. This results in the hand mesh being already rendered, while the joint data hasn't been set. This change will now make sure the hand mesh is only when there is actual joint data available.
jloehr
requested review from
david-c-kline,
keveleigh,
RogPodge and
MaxWang-MS
as code owners
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
RogPodge
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is a timing when the hand controller is already tracked and provides a position, though no joint data is available yet. I.e. when you move hands quickly into the HL2 tracking view. This results in the hand mesh being rendered already, while the joint data hasn't been set and the mesh is stuck at origin.
This change will now make sure the hand mesh is only rendered when there is actual joint data available.
Changes