Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lib declaration for RegExp#unicodeSets #57111

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Add lib declaration for RegExp#unicodeSets #57111

merged 8 commits into from
Mar 18, 2024

Conversation

Josh-Cena
Copy link
Contributor

Fixes #57055

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 21, 2024
sandersn
sandersn approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good as-is, but now that it's reviewed, feel free to fix any duped words or typos you want. It's the perfect place to do so.

This should wait until 5.4 beta is over since it's not a bug fix.

@sandersn sandersn self-assigned this Feb 15, 2024
@Josh-Cena
Copy link
Contributor Author

I think this is good to go

@sandersn
Copy link
Member

Some tests failed last time CI ran. Does this need to have main merged into it? Or is it the code itself that is failing?

@Josh-Cena
Copy link
Contributor Author

Mmm, apparently there are other config files that need to be changed but I'm unaware of.

@Josh-Cena
Copy link
Contributor Author

Wow, the number of baselines updated by an extra lib is surprising.

@Josh-Cena
Copy link
Contributor Author

Josh-Cena commented Mar 13, 2024 •
edited
Loading

@sandersn Now that 5.4 is out, will this be merged soon? (I will resolve the conflicts when I get to a computer)

@sandersn
Copy link
Member

Thanks for the reminder. I'll double-check it and merge.

@sandersn sandersn merged commit a9460c8 into microsoft:main Mar 18, 2024
26 checks passed
@Josh-Cena Josh-Cena deleted the unicodeSets branch March 19, 2024 00:40
@Josh-Cena Josh-Cena mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing RegExp#unicodeSets
4 participants
@Josh-Cena @sandersn @DanielRosenwasser @typescript-bot