fix56509: return `type` if `tryCreateAwaitedType` fails #58547

iisaduan · 2024-05-15T19:55:41Z

Bisected to #49748

rbuckton

I'd prefer the type be spelled correctly in the test even though it was misspelled in the original issue. Otherwise, this looks good to me.

tests/cases/compiler/awaitedTypeNoLib.ts

jakebailey · 2024-05-15T20:05:12Z

@typescript-bot test it

typescript-bot · 2024-05-15T20:05:14Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-15T20:31:55Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-15T20:34:21Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58547/merge:

Everything looks good!

typescript-bot · 2024-05-15T20:50:55Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,461k (± 0.98%)}	_{194,187k (± 1.04%)}	_~	_192,186k	_196,274k	_{p=0.810 n=6}
_{Parse Time}	_{1.55s (± 1.91%)}	_{1.55s (± 1.70%)}	_~	_1.51s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.86s (± 0.60%)}	_{0.87s (± 0.97%)}	_~	_0.86s	_0.88s	_{p=0.923 n=6}
_{Check Time}	_{11.33s (± 0.33%)}	_{11.30s (± 0.46%)}	_~	_11.26s	_11.38s	_{p=0.375 n=6}
_{Emit Time}	_{3.16s (± 0.37%)}	_{3.16s (± 0.76%)}	_~	_3.12s	_3.19s	_{p=0.739 n=6}
_{Total Time}	_{16.90s (± 0.37%)}	_{16.88s (± 0.38%)}	_~	_16.81s	_16.99s	_{p=0.520 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,111k (± 0.00%)}	_{1,222,069k (± 0.00%)}	_~	_1,221,984k	_1,222,156k	_{p=0.230 n=6}
_{Parse Time}	_{8.12s (± 0.67%)}	_{8.11s (± 0.55%)}	_~	_8.06s	_8.17s	_{p=1.000 n=6}
_{Bind Time}	_{2.25s (± 0.54%)}	_{2.24s (± 0.56%)}	_~	_2.23s	_2.26s	_{p=0.101 n=6}
_{Check Time}	_{36.40s (± 0.25%)}	_{36.44s (± 0.36%)}	_~	_36.29s	_36.64s	_{p=0.573 n=6}
_{Emit Time}	_{17.52s (± 0.15%)}	_{17.52s (± 0.35%)}	_~	_17.43s	_17.59s	_{p=0.936 n=6}
_{Total Time}	_{64.28s (± 0.18%)}	_{64.30s (± 0.29%)}	_~	_64.08s	_64.62s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,964,176	_1,964,176	_~	_~	_~	_{p=1.000 n=6}
_Types	_819,283	_819,283	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,849,651k (± 0.00%)}	_{1,849,648k (± 0.00%)}	_~	_1,849,573k	_1,849,691k	_{p=0.521 n=6}
_{Parse Time}	_{6.79s (± 0.27%)}	_{6.78s (± 0.26%)}	_~	_6.76s	_6.81s	_{p=0.324 n=6}
_{Bind Time}	_{2.30s (± 1.47%)}	_{2.28s (± 0.36%)}	_~	_2.27s	_2.29s	_{p=0.869 n=6}
_{Check Time}	_{58.76s (± 0.42%)}	_{58.78s (± 0.34%)}	_~	_58.57s	_59.08s	_{p=0.936 n=6}
_{Emit Time}	_{0.14s (± 3.60%)}	_0.14s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{68.00s (± 0.31%)}	_{67.99s (± 0.28%)}	_~	_67.77s	_68.27s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,221	_1,221,220	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,523	_259,523	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,213k (± 3.39%)}	_{2,387,332k (± 3.24%)}	_~	_2,336,341k	_2,487,334k	_{p=0.689 n=6}
_{Parse Time}	_{6.03s (± 1.60%)}	_{5.99s (± 1.40%)}	_~	_5.89s	_6.10s	_{p=0.520 n=6}
_{Bind Time}	_{2.24s (± 1.18%)}	_{2.26s (± 0.91%)}	_~	_2.23s	_2.28s	_{p=0.419 n=6}
_{Check Time}	_{39.86s (± 0.22%)}	_{39.83s (± 0.28%)}	_~	_39.68s	_39.97s	_{p=0.688 n=6}
_{Emit Time}	_{3.24s (± 4.86%)}	_{3.14s (± 2.17%)}	_~	_3.03s	_3.21s	_{p=0.261 n=6}
_{Total Time}	_{51.39s (± 0.43%)}	_{51.23s (± 0.31%)}	_~	_51.08s	_51.48s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,221	_1,221,220	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,523	_259,523	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,978k (± 0.02%)}	_{2,413,299k (± 0.03%)}	_~	_2,412,502k	_2,413,971k	_{p=0.471 n=6}
_{Parse Time}	_{5.27s (± 0.64%)}	_{5.26s (± 0.63%)}	_~	_5.22s	_5.31s	_{p=0.572 n=6}
_{Bind Time}	_{1.70s (± 0.80%)}	_{1.70s (± 0.30%)}	_~	_1.69s	_1.70s	_{p=0.794 n=6}
_{Check Time}	_{34.25s (± 0.30%)}	_{34.32s (± 0.26%)}	_~	_34.20s	_34.46s	_{p=0.230 n=6}
_{Emit Time}	_{2.68s (± 2.41%)}	_{2.71s (± 2.42%)}	_~	_2.60s	_2.78s	_{p=0.689 n=6}
_{Total Time}	_{43.92s (± 0.12%)}	_{43.98s (± 0.31%)}	_~	_43.86s	_44.22s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,767	_256,766	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,587	_104,587	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,068k (± 0.01%)}	_{426,076k (± 0.01%)}	_~	_426,023k	_426,156k	_{p=0.810 n=6}
_{Parse Time}	_{4.14s (± 0.59%)}	_{4.15s (± 0.28%)}	_~	_4.14s	_4.17s	_{p=0.367 n=6}
_{Bind Time}	_{1.61s (± 1.02%)}	_{1.61s (± 0.85%)}	_~	_1.60s	_1.63s	_{p=1.000 n=6}
_{Check Time}	_{22.11s (± 0.22%)}	_{22.16s (± 0.50%)}	_~	_22.00s	_22.30s	_{p=0.468 n=6}
_{Emit Time}	_{1.71s (± 1.69%)}	_{1.72s (± 0.73%)}	_~	_1.70s	_1.73s	_{p=0.285 n=6}
_{Total Time}	_{29.57s (± 0.14%)}	_{29.65s (± 0.41%)}	_~	_29.49s	_29.77s	_{p=0.422 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,854k (± 0.03%)}	_{369,825k (± 0.03%)}	_~	_369,700k	_369,972k	_{p=0.689 n=6}
_{Parse Time}	_{3.52s (± 1.32%)}	_{3.51s (± 0.94%)}	_~	_3.45s	_3.54s	_{p=0.568 n=6}
_{Bind Time}	_{1.93s (± 1.33%)}	_{1.94s (± 0.78%)}	_~	_1.92s	_1.96s	_{p=0.397 n=6}
_{Check Time}	_{19.35s (± 0.33%)}	_{19.34s (± 0.26%)}	_~	_19.31s	_19.44s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.80s (± 0.44%)}	_{24.79s (± 0.18%)}	_~	_24.73s	_24.86s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,823,941	_2,823,941	_~	_~	_~	_{p=1.000 n=6}
_Types	_957,912	_957,912	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,996,235k (± 0.00%)}	_{2,996,296k (± 0.00%)}	_~	_2,996,207k	_2,996,378k	_{p=0.128 n=6}
_{Parse Time}	_{13.82s (± 0.19%)}	_{13.79s (± 0.14%)}	_~	_13.76s	_13.81s	_{p=0.063 n=6}
_{Bind Time}	_{4.14s (± 0.29%)}	_{4.14s (± 0.34%)}	_~	_4.12s	_4.16s	_{p=0.743 n=6}
_{Check Time}	_{73.29s (± 0.31%)}	_{73.37s (± 0.33%)}	_~	_73.01s	_73.62s	_{p=0.748 n=6}
_{Emit Time}	_{23.50s (± 0.70%)}	_{23.49s (± 0.40%)}	_~	_23.32s	_23.60s	_{p=0.936 n=6}
_{Total Time}	_{114.75s (± 0.34%)}	_{114.79s (± 0.28%)}	_~	_114.37s	_115.08s	_{p=0.748 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,602k (± 0.02%)}	_{410,626k (± 0.02%)}	_~	_410,533k	_410,756k	_{p=1.000 n=6}
_{Parse Time}	_{3.18s (± 0.51%)}	_{3.19s (± 0.55%)}	_~	_3.17s	_3.22s	_{p=0.413 n=6}
_{Bind Time}	_{1.40s (± 1.18%)}	_{1.39s (± 0.45%)}	_~	_1.38s	_1.40s	_{p=0.438 n=6}
_{Check Time}	_{14.42s (± 0.45%)}	_{14.42s (± 0.58%)}	_~	_14.32s	_14.53s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.00s (± 0.30%)}	_{19.00s (± 0.46%)}	_~	_18.88s	_19.12s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,639	_524,639	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,906	_178,906	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,676k (± 0.01%)}	_{462,664k (± 0.01%)}	_~	_462,616k	_462,699k	_{p=0.688 n=6}
_{Parse Time}	_{2.61s (± 0.20%)}	_{2.60s (± 0.38%)}	_~	_2.59s	_2.61s	_{p=0.417 n=6}
_{Bind Time}	_{0.98s (± 0.56%)}	_{0.97s (± 1.25%)}	_~	_0.96s	_0.99s	_{p=0.137 n=6}
_{Check Time}	_{15.34s (± 0.19%)}	_{15.40s (± 0.60%)}	_~	_15.25s	_15.48s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.93s (± 0.15%)}	_{18.97s (± 0.43%)}	_~	_18.84s	_19.07s	_{p=0.199 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-15T21:58:35Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58547/merge:

Everything looks good!

return type if tryCreateAwaitedType fails

0dc054c

iisaduan requested a review from rbuckton May 15, 2024 19:55

typescript-bot assigned iisaduan May 15, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 15, 2024

rbuckton approved these changes May 15, 2024

View reviewed changes

tests/cases/compiler/awaitedTypeNoLib.ts Outdated Show resolved Hide resolved

iisaduan added 2 commits May 15, 2024 13:07

update comment

7e89f2f

rename thennable -> thenable

4376242

iisaduan changed the title ~~return type if tryCreateAwaitedType fails~~ fix56509: return type if tryCreateAwaitedType fails May 15, 2024

rbuckton approved these changes May 15, 2024

View reviewed changes

RyanCavanaugh approved these changes May 16, 2024

View reviewed changes

iisaduan merged commit 4da470d into microsoft:main May 16, 2024
28 checks passed

iisaduan deleted the awaitedTypeNoLib branch July 9, 2024 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix56509: return `type` if `tryCreateAwaitedType` fails #58547

fix56509: return `type` if `tryCreateAwaitedType` fails #58547

iisaduan commented May 15, 2024

rbuckton left a comment

jakebailey commented May 15, 2024

typescript-bot commented May 15, 2024 •

edited

Loading

typescript-bot commented May 15, 2024

typescript-bot commented May 15, 2024

typescript-bot commented May 15, 2024

tsc

typescript-bot commented May 15, 2024

fix56509: return type if tryCreateAwaitedType fails #58547

fix56509: return type if tryCreateAwaitedType fails #58547

Conversation

iisaduan commented May 15, 2024

rbuckton left a comment

Choose a reason for hiding this comment

jakebailey commented May 15, 2024

typescript-bot commented May 15, 2024 • edited Loading

typescript-bot commented May 15, 2024

typescript-bot commented May 15, 2024

typescript-bot commented May 15, 2024

tsc

typescript-bot commented May 15, 2024

fix56509: return `type` if `tryCreateAwaitedType` fails #58547

fix56509: return `type` if `tryCreateAwaitedType` fails #58547

typescript-bot commented May 15, 2024 •

edited

Loading