Move maybe::operator== back from maybe_common to maybe implementations #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move of the maybe::operator== from the two variants to the common
base maybe_common causes an ambiguity with the allocator operator==
from libstdc++ in GCC 9.1. Moving them back to the variants fixes this
issue.
More detailed description:
When compiling Bond 8.1 code with gcc 9.1.0 / the current libstdc++, I get an ambiguous overload error for the
from maybe.h line 195. The ambiguous other operator being
from allocator.h:168 (and another similar one from new_allocator.h).
Moving the shared operator== implementation from maybe_common to both of the maybe variants fixes the issue, but I'm not sure if this is the best approach. See the attached patch. I'm also not sure what else would need to be updated.