Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 16.04 images cannot be pulled #979

Closed
chwarr opened this issue Jun 5, 2019 · 1 comment · Fixed by #980
Closed

Ubuntu 16.04 images cannot be pulled #979

chwarr opened this issue Jun 5, 2019 · 1 comment · Fixed by #980
Assignees
@chwarr
Labels
bug

Comments

@chwarr
Copy link
Member

chwarr commented Jun 5, 2019

The CI image repository no longer has the CI images that are referenced by .travis.yml anymore. It appears that the clean up script is now too aggressive in deleting them.
@chwarr chwarr self-assigned this Jun 5, 2019
@chwarr chwarr added the bug label Jun 5, 2019
@chwarr
Copy link
Member Author

chwarr commented Jun 5, 2019

I'll be able to look into this next week at the earliest.

@chwarr chwarr mentioned this issue Jun 5, 2019
Merged
chwarr added a commit to chwarr/bond that referenced this issue Jun 11, 2019
@chwarr
Refresh Linux CI build image
30f8122 
Updates the Linux CI build image to build-22756092 which was built
against commit 62da781.

Due to a combination of two bugs in the clean up script, we've lost all
the images except for the one reference by the 8.1.0 tag,
build-13234037.

1. The clean up script was supposed to be configured to retain images
   reference by all tags. However, it was only retaining the image
   reference by the most recent tag. This was fixed by using `git
   rev-list --tags --simplify-by-decoration --dense` instead of `git
   rev-list --tags -n 1`
1. The clean up script was configured to retain images reference by the
   last two weeks of commits. There has been a period without any
   commits in two weeks, so the images reference by the current tip of
   master were collected. This has been fixed by adding the results of
   `git rev-list --reverse -n 10 origin/master` to the set of root
   commits.

Fixes microsoft#979
@chwarr chwarr mentioned this issue Jun 11, 2019
Merged
chwarr added a commit that referenced this issue Jun 12, 2019
@chwarr
Refresh Linux CI build image
c8a259f 
Updates the Linux CI build image to build-22756092 which was built
against commit 62da781.

Due to a combination of two bugs in the clean up script, we've lost all
the images except for the one reference by the 8.1.0 tag,
build-13234037.

1. The clean up script was supposed to be configured to retain images
   reference by all tags. However, it was only retaining the image
   reference by the most recent tag. This was fixed by using `git
   rev-list --tags --simplify-by-decoration --dense` instead of `git
   rev-list --tags -n 1`
2. The clean up script was configured to retain images reference by the
   last two weeks of commits. There has been a period without any
   commits in two weeks, so the images reference by the current tip of
   master were collected. This has been fixed by adding the results of
   `git rev-list --reverse -n 10 origin/master` to the set of root
   commits.

Fixes #979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chwarr chwarr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refresh Linux CI build image chwarr/bond
1 participant
@chwarr