Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Linux CI build image #980

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

chwarr
Copy link
Member

@chwarr chwarr commented Jun 11, 2019

Updates the Linux CI build image to build-22756092 which was built
against commit 62da781.

Due to a combination of two bugs in the clean up script, we've lost all
the images except for the one reference by the 8.1.0 tag,
build-13234037.

  1. The clean up script was supposed to be configured to retain images
    reference by all tags. However, it was only retaining the image
    reference by the most recent tag. This was fixed by using git rev-list --tags --simplify-by-decoration --dense instead of git rev-list --tags -n 1
  2. The clean up script was configured to retain images reference by the
    last two weeks of commits. There has been a period without any
    commits in two weeks, so the images reference by the current tip of
    master were collected. This has been fixed by adding the results of
    git rev-list --reverse -n 10 origin/master to the set of root
    commits.

Fixes #979

Updates the Linux CI build image to build-22756092 which was built
against commit 62da781.

Due to a combination of two bugs in the clean up script, we've lost all
the images except for the one reference by the 8.1.0 tag,
build-13234037.

1. The clean up script was supposed to be configured to retain images
   reference by all tags. However, it was only retaining the image
   reference by the most recent tag. This was fixed by using `git
   rev-list --tags --simplify-by-decoration --dense` instead of `git
   rev-list --tags -n 1`
1. The clean up script was configured to retain images reference by the
   last two weeks of commits. There has been a period without any
   commits in two weeks, so the images reference by the current tip of
   master were collected. This has been fixed by adding the results of
   `git rev-list --reverse -n 10 origin/master` to the set of root
   commits.

Fixes microsoft#979
@chwarr chwarr merged commit c8a259f into microsoft:master Jun 12, 2019
@chwarr chwarr deleted the rev-linux-image branch June 12, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 16.04 images cannot be pulled
2 participants