Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock for protocol MockFirmwareVolumeBlock under MdePkg #1216

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

Rasheed-Yusuf
Copy link
Contributor

@Rasheed-Yusuf Rasheed-Yusuf commented Nov 12, 2024

Description

Add Mock for Firmware Volume Block Protocol in MdePkg

Signed-off-by: rasheed yusuf [email protected]
Cc: Maintainer Shruti Gupta [email protected]
Cc: Reviewer Shruti Gupta [email protected]

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Consumed in a GoogleTest

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch. labels Nov 12, 2024
@Rasheed-Yusuf
Copy link
Contributor Author

Rasheed-Yusuf commented Nov 12, 2024 via email

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.60%. Comparing base (465a5f9) to head (561c128).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1216   +/-   ##
===========================================
  Coverage        1.60%    1.60%           
===========================================
  Files            1377     1377           
  Lines          359246   359246           
  Branches         5524     5524           
===========================================
  Hits             5760     5760           
  Misses         353379   353379           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
MdePkg 5.60% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rasheed-Yusuf
Copy link
Contributor Author

Rasheed-Yusuf commented Nov 12, 2024 via email

Rasheed-Yusuf and others added 8 commits December 12, 2024 11:19
Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockFirmwareVolumeBlock.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>
…eBlock.h

Co-authored-by: Michael Kubacki <[email protected]>
Signed-off-by: Rasheed-Yusuf <[email protected]>
…eBlock.h

Co-authored-by: Vivian Nowka-Keane <[email protected]>
Signed-off-by: Rasheed-Yusuf <[email protected]>
Review changes to use #define for MOCK_EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL_INSTANCE definition.

Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockFirmwareVolumeBlock.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>

Signed-off-by: Rasheed-Yusuf <[email protected]>
Fixes for CI Build errors

Signed-off-by: Rasheed-Yusuf <[email protected]>
@VivianNK VivianNK enabled auto-merge (squash) December 12, 2024 19:20
@VivianNK VivianNK merged commit f72f269 into microsoft:dev/202405 Dec 12, 2024
31 checks passed
ProjectMuBot pushed a commit that referenced this pull request Dec 12, 2024
## Description

Add Mock for Firmware Volume Block Protocol in MdePkg

Signed-off-by: rasheed yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

Consumed in a GoogleTest

## Integration Instructions

N/A

---------

Signed-off-by: Rasheed Yusuf <[email protected]>
Signed-off-by: Rasheed-Yusuf <[email protected]>
Co-authored-by: Michael Kubacki <[email protected]>
Co-authored-by: Vivian Nowka-Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants