This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[dedicated vc] management tool #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mzmssg
force-pushed
the
zimiao/dedicate_vc_tool
branch
3 times, most recently
from
c78b3a5 to
7e958cd
Compare
mzmssg
force-pushed
the
zimiao/dedicate_vc_tool
branch
from
7e958cd to
f260369
Compare
abuccts
reviewed
Jun 14, 2019
| if nodes_info[node]["nodeLabel"] in dedicate_queues: | ||
| dedicate_queues[nodes_info[node]["nodeLabel"]]["nodes"].append(node) | ||
| for queue_name, queue_attr in dedicate_queues.items(): | ||
| print(queue_name + ":") |
There was a problem hiding this comment.
is this file py2 or py3? could you make it compatible?
There was a problem hiding this comment.
it's a dev-box script with python2, I made some compatible fix, but not fully tested, expecially unittest part.
abuccts
reviewed
Jun 14, 2019
|
@abuccts |
abuccts
approved these changes
Jun 14, 2019
mzmssg
added a commit
that referenced
this pull request
Jun 19, 2019
* add dedicated vc * add dedicated vc(2) * add dedicated vc(3) * add description * [exporter] add yarn node label support (#2869) * add yarn node-label support in exporter * store string insead of list * remove non-numeric value * no * add dedicated vc(4) * add cmdline tool link * common to shared * typo * add dedicated vc description spacing * change vc style * add vc title info icon * virtual clusters tab bar * remove yarn.lock * virtual clusters tab bar(3) * remove yarn.lock * Revert "remove yarn.lock" This reverts commit 7d3fde1. * revert package.json & yarn.lock * readd office-ui-fabric-js * [dedicated vc] rest api (#2921) * dedicated vc rest api * Revert "dedicated vc rest api" This reverts commit 33224c2. * dedicated vc rest api * virtual clusters tab bar(4) * return to the vc style with the icon * Revert "return to the vc style with the icon" This reverts commit 85b4f88. * return to the vc style with the icon * [dedicated vc] management tool (#2923) * dedicated vc management tool * doc * remove .gitignore unnecessary lines * fix * compatible fix * add lisence, unify quotation * [webportal]remove the vc page information icon (#2936) * remove the vc description icon * remove fabric-js in yarn.lock&package.json * adjust the height of the table * remove package-lock * removed files * doc ifx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of #2790