Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[webportal]remove the vc page information icon #2936

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Conversation

fenghuajia
Copy link
Contributor

No description provided.

@fenghuajia fenghuajia requested a review from mzmssg June 13, 2019 08:47
@coveralls
Copy link

coveralls commented Jun 13, 2019

Coverage Status

Coverage remained the same at 53.766% when pulling 121153e on add_vc into 030aee7 on dedicated_vc.

@@ -4,8 +4,6 @@ require('datatables.net-bs/js/dataTables.bootstrap.js');
require('datatables.net-bs/css/dataTables.bootstrap.css');
require('datatables.net-plugins/sorting/natural.js');
require('datatables.net-plugins/sorting/title-numeric.js');
require('office-ui-fabric-js/dist/css/fabric.min.css');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we still need office-ui-fabric-js in other parts? If no, we could remove it in package.json and yarn.lock

@mzmssg mzmssg requested a review from abuccts June 16, 2019 13:06
@fenghuajia fenghuajia merged commit 7216179 into dedicated_vc Jun 18, 2019
@fenghuajia fenghuajia deleted the add_vc branch June 18, 2019 03:19
mzmssg added a commit that referenced this pull request Jun 19, 2019
* add dedicated vc

* add dedicated vc(2)

* add dedicated vc(3)

* add description

* [exporter] add yarn node label support (#2869)

* add yarn node-label support in exporter

* store string insead of list

* remove non-numeric value

* no

* add dedicated vc(4)

* add cmdline tool link

* common to shared

* typo

* add dedicated vc description spacing

* change vc style

* add vc title info icon

* virtual clusters tab bar

* remove yarn.lock

* virtual clusters tab bar(3)

* remove yarn.lock

* Revert "remove yarn.lock"

This reverts commit 7d3fde1.

* revert package.json & yarn.lock

* readd office-ui-fabric-js

* [dedicated vc] rest api (#2921)

* dedicated vc rest api

* Revert "dedicated vc rest api"

This reverts commit 33224c2.

* dedicated vc rest api

* virtual clusters tab bar(4)

* return to the vc style with the icon

* Revert "return to the vc style with the icon"

This reverts commit 85b4f88.

* return to the vc style with the icon

* [dedicated vc] management tool (#2923)

* dedicated vc management tool

* doc

* remove .gitignore unnecessary lines

* fix

* compatible fix

* add lisence, unify quotation

* [webportal]remove the vc page information icon (#2936)

* remove the vc description icon

* remove fabric-js in yarn.lock&package.json

* adjust the height of the table

* remove package-lock

* removed files

* doc ifx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants