Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Additions to docker instance? #3529

Closed
Westbrook opened this issue Aug 19, 2020 · 1 comment · Fixed by #3651
Closed

[Feature] Additions to docker instance? #3529

Westbrook opened this issue Aug 19, 2020 · 1 comment · Fixed by #3651
Assignees
@aslushnikov

Comments

@Westbrook
Copy link
Contributor

I'm attempting to use Playwright with CircleCI and when doing a checkout I get the following warning:

Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed.

I later get a message about yarn not being available as well.

Would it be possible to add these to the image?
@aslushnikov aslushnikov self-assigned this Aug 21, 2020
@aslushnikov
Copy link
Collaborator

Would it be possible to add these to the image?

@Westbrook For sure!

@aslushnikov aslushnikov mentioned this issue Aug 21, 2020
Closed
@Westbrook Westbrook mentioned this issue Aug 25, 2020
Merged
8 tasks
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Aug 26, 2020
@aslushnikov
devops: add yarn and git in the docker container
7ae6879 
This will help consuming docker image as an env for test execution.

Fixes microsoft#3529.
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Aug 26, 2020
@aslushnikov
devops: add yarn and git in the docker container
c52e856 
This will help consuming docker image as an env for test execution.

Fixes microsoft#3529.
@aslushnikov aslushnikov mentioned this issue Aug 26, 2020
Merged
aslushnikov added a commit that referenced this issue Aug 27, 2020
@aslushnikov
devops: add yarn and git in the docker container (#3651)
3ea3cf0 
This will help consuming docker image as an env for test execution.

Fixes #3529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

devops: add yarn and git in the docker container aslushnikov/playwright
2 participants
@aslushnikov @Westbrook