Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: add yarn and git in the docker container #3651

Merged

Conversation

aslushnikov
Copy link
Collaborator

This will help consuming docker image as an env for test execution.

Fixes #3529.

This will help consuming docker image as an env for test execution.

Fixes microsoft#3529.
@aslushnikov aslushnikov merged commit 3ea3cf0 into microsoft:master Aug 27, 2020
@aslushnikov aslushnikov deleted the install-git-and-yarn-in-docker branch August 27, 2020 03:16
@Westbrook
Copy link
Contributor

Nice! How long does it usually take for something like this to become available when requesting from CircleCI for example?

@arjunattam
Copy link
Contributor

@Westbrook you can use this today with the next tag: microsoft/playwright:next. The latest tag will be moved on the next release (some time in early September)

@Westbrook
Copy link
Contributor

Thanks for the info @arjun27, would that look like: mcr.microsoft.com/playwright:next for usage in something like CircleCI? I'm not seeing the addition of yarn and git when leveraging that image.

@arjunattam
Copy link
Contributor

arjunattam commented Aug 28, 2020

Thanks for checking. I was able to repro this locally: mcr.microsoft.com/playwright:next does not have git/yarn installed. This was the Actions run that pushed the playwright:next and playwright:sha-3ea3cf0 tags.

  • mcr.microsoft.com/playwright:sha-3ea3cf0 is working locally with git and yarn, and can be used as a step-gap before the next release
  • mcr.microsoft.com/playwright:next not working is a bug and needs investigation. My observations:
    • The docker push to next tag from the Actions run was successful
    • On ACR portal, I can see that the next tag was updated with the same timestamp as sha-3ea3cf0
    • Pulling playwright.azurecr.io/public/playwright:next works – it has git/yarn on it
    • The mirroring between the playwright ACR subscription and mcr.microsoft.com seems to be broken, and mcr.microsoft.com/playwright:next does not have git/yarn installed
    • I'll reach out to the MCR team since this seems to be an issue at that layer

fyi @aslushnikov

@arjunattam
Copy link
Contributor

@Westbrook, the next tag should be working now. I've verified it locally.

@Westbrook
Copy link
Contributor

Cool. I will check that out, the :sha-3ea3cf0 had gotten me on the right path, at least enough to find one more thing I'd like added to the image, but I'll create a new issue to track that. Thanks for all your help on the @arjun27!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Additions to docker instance?
4 participants