-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle targets fail when path contains spaces #7597
Comments
Seems like we need some extra quotes around input with possible spaces in our MSBuild targets running bundle commands. |
Thanks for looking into this, is there a possibility to back-port this to 0.64? |
Fixes microsoft#7597 We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces.
Fixes microsoft#7597 We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces.
* Fix MSBuild Bundling When Path Contains Spaces Fixes #7597 We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces. * Change files
* Fix MSBuild Bundling When Path Contains Spaces Fixes #7597 We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces. * Change files Co-authored-by: Andrew Coates <[email protected]>
Please reopen, this is still not working as of RN 0.65 |
New regression in 0.65. Issue is in the dependencies script, according to the screenshot. cc @asklar |
Worth adding a regression test that has a space so we catch issues like this earlier. |
The bug is not in the dependencies script (the error is that the dependencies script cannot be run). The bug is in the doctor/healthcheck code: |
It´s not a big issue when you know what´s happening as you can avoid it. But it would be nice if it works.
Similar to this old issue
Environment
Run the following in your terminal and copy the results here.
npx react-native --version
: 5.0.1-alpha.2npx react-native info
:Steps To Reproduce
C:/Code/React Native
npx react-native init MyTSApp --template react-native-template-typescript cd MyTSApp
cd MyTsApp
and runnpx react-native-windows-init --overwrite --language cs
yarn
Expected Results
It should create the App Package but it fails.
Snack, code example, screenshot, or link to a repository:
Error:
'C:\Code\React'
"npx --no-install react-native bundle --platform windows --entry-file index.js --bundle-output C:\Code\React Native\samplepp\windows\samplepp\Bundle\index.windows.bundle --assets-dest C:\Code\React Native\samplepp\windows\samplepp\Bundle --dev false --reset-cache --sourcemap-output C:\Code\React Native\samplepp\windows\samplepp\bin\x86\Release\sourcemaps\react\index.windows.bundle.map "
exited with code 1. sampleppError when trying to create de package
The text was updated successfully, but these errors were encountered: