Fix MSBuild Bundling When Path Contains Spaces

[NickGerleman]

Fixes #7597

We're passing raw strings into the exec string for running commands from MSBuild. Paths with spaces will be interpreted as multiple CLI args. Wrap paths in quotes to fix paths with spaces.

Microsoft Reviewers: Open in CodeFlow

[asklar]

main thing to watch out for is whether any of the arguments that you're adding quotes to, might themselves have quotes in them.
Ideally we don't insert the quotes ourselves and instead use something like NormalizePath or one of the Path functions to ensure the path is correctly quoted

[NickGerleman]

main thing to watch out for is whether any of the arguments that you're adding quotes to, might themselves have quotes in them.
Ideally we don't insert the quotes ourselves and instead use something like NormalizePath or one of the Path functions to ensure the path is correctly quoted

I did a (quick) scan looking for the pattern. Mostly just followed the chain of MSBuild props to where we wrap quotes. I didn't see any quote literals, and we were using MSBuild path functions.

[ghost]

Hello @NickGerleman!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 29 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.