Epic: Fix remaining issues with non-client drawing

[DHowett-MSFT]

Misc. Window Management bucket

• Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?)
• Windows notifications gets on silent mode #1840 When we're maximized, the system thinks we're a full-screen app. We need to jiggle the window by 1px or something.

Others:

• Make sure MinMaxCloseControl supports FullScreen & Tablet Mode #2001 Make sure MinMaxCloseControl supports FullScreen & Tablet Mode
• When a dialog is open, the titlebar is the wrong color #2100 When a dialog is open, the titlebar is the wrong color
  • Also: Investigate Acrylic in titlebar / not using a HRGN for the titlebar #4744 Investigate Acrylic in titlebar / not using a HRGN for the titlebar
• New terminal does not handle theme change event. #1230 I have to restart the new terminal to see the effects of changing between light and dark windows theme.
• Do not pad tabs from the top when maximized or fullscreen #2541 When the window is maximized, there should be no padding above the tabs
• Windows Terminal does not open with button displaying "maximized" state #3440 Windows Terminal does not open with button displaying "maximized" state
• Maximize and minimize window buttons incorrect rendering #4288 Maximize and minimize window buttons incorrect rendering
• strange bar appear while maximized strange bar appear while maximized #8384

Fixed in `master`

• Suspicious remains of previous window borders flash up when closing the window (Suspicious remains of previous window borders flash up when closing the window #3222) (PR#3394)
• White border at the bottom of the window. (White border at the bottom of the window. #3064) (PR Use standard 1px window borders on NC Island Window #3394)
• Stop creating and throwing away so many HRGNs during move-size. (PR Use standard 1px window borders on NC Island Window #3394)
• Window Border expands when showTabsInTitlebar is enabled #3136 we learned that CXDRAG and CYDRAG are not the right things to use; use the right things. (PR Use standard 1px window borders on NC Island Window #3394)
• Thick white border around window when showTabsInTitlebar enabled #1307 Thick border around window, and drag handles should not be only over that border. (PR Use standard 1px window borders on NC Island Window #3394)
• Lots of work is duplicated when NonClientIslandWindow is resized and the drag bar size changes #1897 There's a bunch of duplicated work, well, everywhere. (PR Use standard 1px window borders on NC Island Window #3394)
• make the window border have distinct edges (right now it blends in with white/black things); consider the user's accent color somehow?
  • Could this be solved just by not NCPAINTing, and letting DWM draw our window shadow again?

Possibly related:

• Window border width does not respect system theme #1859 The border width should match the value from the system theme

Fixed in <0.6

• Switch from _ - X to real or real-looking caption controls

Definitely related, because we're handling WM_NCPAINT:

• [huge bucket] look at getting the window shadow back (PR Don't NCPAINT our window, PAINT our window #1898)
• make the window border less round on top (PR Don't NCPAINT our window, PAINT our window #1898)

Maybe related:

• make the window border less painfully black/white

Misc. Window Management bucket

• consider giving NonClientIslandWindow knowledge about its caption button box for a more direct connection (PR Enable dragging with the entire titlebar #1948)
• Double clicking on the drag bar to maximize does not update the maximize button icon #1780 Double clicking on the drag bar to maximize does not update the maximize button icon
• Make sure maximize button maintains correct state when window is maximized in any manner
• Left side of text is cut off when maximizing windows terminal on non-primary monitor #1055 Window edges are cut off when the window is maximized on a secondary display (PR Fix wrong maximized window offset on non primary monitors #1921)
• Flyout/Dropdown light dismiss not working with Titlebar click #2028 Clicking on the TitleBar does not close the dropdown menu
• Maximizing terminal when window is across two monitors causes bars to bleed across monitor. #2268 Maximizing terminal when window is across two monitors causes bars to bleed across monitor.

Others:

• Bug Report: Dark Theme requires settings reload #1913 Dark Theme requires settings reload (PR Make sure to apply the theme on load of the application #2107)

[DHowett-MSFT]

We need to handle the window message for theme change probably.

[zadjii-msft]

Closing this one out since #2001 is really the only thing left in it.