Update js-beautify to 1.8.0-rc4 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@bitwiseman Thanks a lot! |
|
@bitwiseman Should I surface wrapAttributes: 'aligned-multiple' and |
|
You should go ahead and add the new options and values. We won't be
replacing them in the short term.
As to the description, "attributes that wrap will align vertically ,
multiple attributes are allowed per line".
…On Mon, Aug 6, 2018, 6:53 AM Martin Aeschlimann ***@***.***> wrote:
@bitwiseman <https://github.com/bitwiseman> Should I surface
wrapAttributes: 'aligned-multiple' and wrapAttributesIndentSize, or do
you plan to replace these very soon?
Also, I couldn't find a compact description of what aligned-multiple
does...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB3kKUneVGyYMCMhhYAEHdbckyeumTI3ks5uOEp1gaJpZM4VuorD>
.
|
|
Thanks a lot! I'll surface the new settings ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aeschli
1.8.0-rc4 Fixes several breaking bugs in 1.8.0-rc2. In particular beautifier/js-beautify#1464 - where element casing was not being preserved.
Please consider taking this update.