Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] update to jsbeautify 1.8.0-rc2. #53546

Closed
ghost opened this issue Jul 4, 2018 · 7 comments
Closed

[html] update to jsbeautify 1.8.0-rc2. #53546

ghost opened this issue Jul 4, 2018 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality html HTML support issues
Milestone

Comments

@ghost
Copy link

ghost commented Jul 4, 2018

Issue Type: Bug

[HTML, Format Doc / js-beautify] comment behind tag is formated as comment above next tag:

for example:

<script src="/lib/jquery.js"></script> <!-- jquery library -->
<script src="sw.js"><script>

is formated as

<script src="/lib/jquery.js"></script>
<!-- jquery library -->
<script src="sw.js"><script>

VS Code version: Code 1.24.1 (24f6262, 2018-06-13T17:51:32.889Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.88GB (12.39GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions: none
@jrieken
Copy link
Member

jrieken commented Jul 5, 2018

@Mlocik97-issues What extension are you using to format html?

@ghost
Copy link
Author

ghost commented Jul 5, 2018

Extensions: none

only integrated js-beautify

@jrieken jrieken removed the info-needed Issue requires more information from poster label Jul 5, 2018
@bitwiseman
Copy link

@Mlocik97-issues
beautifier/js-beautify#1337

@ghost
Copy link
Author

ghost commented Jul 5, 2018

@bitwiseman can I ask, when it will be aplicated in vs code? will it be in "June" Recovery patch?

@bitwiseman
Copy link

bitwiseman commented Jul 8, 2018

1.8.0-rc2. I don't know about whether this requires an update to vscode.

@aeschli aeschli changed the title [HTML, Format Doc / js-beautify] comment behind tag is formated as comment above next tag [html] comment behind tag is formated as comment above next tag Jul 9, 2018
@aeschli aeschli changed the title [html] comment behind tag is formated as comment above next tag [html] update to jsbeautify 1.8.0-rc2. Jul 9, 2018
@aeschli aeschli added this to the July 2018 milestone Jul 9, 2018
@aeschli aeschli added feature-request Request for new features or functionality html HTML support issues labels Jul 9, 2018
aeschli added a commit to microsoft/vscode-html-languageservice that referenced this issue Jul 9, 2018
@aeschli
Copy link
Contributor

aeschli commented Aug 3, 2018

1.8.0-rc2 is now in 1.26.0.
However, I still have to surface the wrap_attributes_indent_size and aligned-multiple options. I created #55743.

@aeschli aeschli closed this as completed Aug 3, 2018
@bitwiseman
Copy link

@aeschli
Please consider taking microsoft/vscode-html-languageservice#31 - update to 1.8.0-rc4. It has significantly better performance and fixes a few sev1 bugs.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Development

No branches or pull requests

3 participants