Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron 25 #184021

Closed
7 tasks done
deepak1556 opened this issue Jun 1, 2023 · 34 comments · Fixed by #188268
Closed
7 tasks done

Update to Electron 25 #184021

deepak1556 opened this issue Jun 1, 2023 · 34 comments · Fixed by #188268
Assignees
Labels
electron Issues and items related to Electron electron-25-update engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Jun 1, 2023

Todo

@fisforfaheem
Copy link

Please consider Electron 25 it has much better performance and stability

@deepak1556 deepak1556 changed the title Update to Electron 24 Update to Electron 24/25 Jun 8, 2023
@lorand-horvath
Copy link

lorand-horvath commented Jun 9, 2023

Please consider Electron 25 it has much better performance and stability

And of course, no backward compatibility. As for stability, how can one say the first couple releases of a major version are stable? Electron 25.0.0 is barely 2 weeks old!
I said it many times before... stop asking for bleeding edge software, there are and always will be many bugs in them. Do you like your VSCode having all kinds of weird issues? I don't.
I think even Electron 24 is too early to jump on - it was first released in April.

Edit: downvote away, be my guest :-)

@fisforfaheem
Copy link

fisforfaheem commented Jun 9, 2023 via email

@zm-cttae
Copy link

zm-cttae commented Jun 10, 2023

Native node fetch! Very keen on this upgrade. It'll make a lot of my WASM-related code mutch quicker.

PS: I plan to turn my wasm into a data uri and stream it using fetch in 9 months time. To give that VS Code verison time to percolate :)

@tjx666
Copy link
Contributor

tjx666 commented Jun 12, 2023

@lorand-horvath there are two months to test and fix

@fisforfaheem
Copy link

fisforfaheem commented Jun 13, 2023 via email

@tjx666
Copy link
Contributor

tjx666 commented Jul 10, 2023

@deepak1556 will be released in July interation?

@fisforfaheem
Copy link

fisforfaheem commented Jul 10, 2023 via email

@lorand-horvath
Copy link

I agree that using blazing edge electron may get issues. But at least VSCode Insiders should have Electron version 23 or 24 to benefit. I'm not talking about the stable version of VSCode, but the Insider version.

@fisforfaheem That's not how it works; this is the 3rd time you are asking to have Electron 24 only in Insiders.
Insiders is max 1 month ahead of official VSCode, you can verify that yourself. It's basically the beta testing phase.
There's also VSCode Exploration, which is the alpha development phase.

@fisforfaheem
Copy link

fisforfaheem commented Jul 10, 2023 via email

@lorand-horvath
Copy link

lorand-horvath commented Jul 10, 2023

@fisforfaheem You can find VSCode Exploration version 1.75 here:
#166265 (comment)
Install it (it has the orange logo, you'll see), then start and Check for Updates which will get you the latest version 1.81-exploration (alpha).

@deepak1556
Copy link
Collaborator Author

@tjx666 not likely, this iteration will be focused on resolving the two Node.js blockers

  1. Get server executables based on Node v18 to be GLIBC >= 2.17 compatible
  2. Adopt DNS result order changes

@zhouxinghong
Copy link

It works very well! Thank you very much!

@zhouxinghong
Copy link

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 7, 2023
@zhouxinghong
Copy link

@zhouxinghong
Copy link

zhouxinghong commented Aug 16, 2023

https://github.com/electron/electron/releases/tag/v26.0.0
Fixes a lot of bugs included Electron 25 version

@bpasero bpasero moved this from 🏃 In Progress to ✔️ Done / Deferred in VSCode Electron Integration Aug 17, 2023
@tjx666
Copy link
Contributor

tjx666 commented Aug 29, 2023

@deepak1556 any performance improved after upgrade electron v25? I think node18 maybe improve some

@fisforfaheem
Copy link

fisforfaheem commented Aug 30, 2023 via email

@zhouxinghong
Copy link

https://github.com/electron/electron/releases/tag/v26.1.0
https://github.com/electron/electron/releases/tag/v25.8.0
Fixes a lot of bugs included Electron 25 version

@deepak1556
Copy link
Collaborator Author

deepak1556 commented Sep 1, 2023

@tjx666 yes we have seen nice improvements to render process launch times across all platforms, most noticeable on windows with ~80ms drop, there are also some minor script execution time improvements ~20-30ms. However on macOS we lost some time from start till app.isReady which requires investigation. But overall the score is better than Electron 22.

@shannon
Copy link

shannon commented Sep 10, 2023

Just FYI, the following bug is present in Electron 25 and therefore present in the latest release of VS Code: electron/electron#38790

I realize there are probably other bugs in Electron 25 that would be present in VS Code but I ran into this one and I had to figure out if it was VS Code or electron that was the issue.

@lorand-horvath
Copy link

lorand-horvath commented Sep 14, 2023

I will now venture and say (without trying to blame anyone) that the update to Electron 25 was rushed in VSCode 1.82, as I've correctly predicted would happen #184021 (comment) - that strange bugs were going to creep in.
Here's just a couple of them, but I'm sure there are many others (lack of time to track everything going on):
#190437
electron/electron#38790

I'd really like to have an Electron 22 branch build of VSCode still available and maintained, it was much more stable, no serious issues as far as I can see. And it was also working on Windows 7 without problems. But that's too much to ask, I guess.

@donotsdubba

This comment was marked as spam.

@shannon
Copy link

shannon commented Sep 17, 2023

My comment about the bug from Electron 25 being in VS Code was not to disparage the work to do the upgrade or suggest that it should not have been done. I merely wanted to point it out in case anyone else ran into it. It is a very strange bug but not show stopping. Having said that, I think this just reiterates that the work to keep VS Code inline with Electron upgrades (including any bug fixes) is important and should be as streamlined as possible.

Other than this bug, being able to now run and test my WebGPU based code directly inside VS Code has been invaluable.

@microsoft microsoft locked as off-topic and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron electron-25-update engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.