-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Electron 25 #184021
Comments
Please consider Electron 25 it has much better performance and stability |
And of course, no backward compatibility. As for stability, how can one say the first couple releases of a major version are stable? Electron 25.0.0 is barely 2 weeks old! Edit: downvote away, be my guest :-) |
but using an ond chromium engine feels not safe... Also Vscode needs to
focus on improving performance.
[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&>
06/10/23,
02:39:59 AM
…On Fri, Jun 9, 2023 at 2:10 PM Lorand Horvath ***@***.***> wrote:
Please consider Electron 25 it has much better performance and stability
And of course, no backward compatibility. As for stability, how can one
say the first couple releases of a major version are stable? Electron
25.0.0 is barely 2 weeks old!
I said it many times before... stop asking for bleeding edge software,
there are and always will be many bugs in them. Do you like your VSCode
having all kinds of weird issues? I don't.
—
Reply to this email directly, view it on GitHub
<#184021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRXJSEVHWCQVYFSHLP6FUDXKLSAJANCNFSM6AAAAAAYWPFLUU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Native node fetch! Very keen on this upgrade. It'll make a lot of my WASM-related code mutch quicker. PS: I plan to turn my wasm into a data uri and stream it using fetch in 9 months time. To give that VS Code verison time to percolate :) |
@lorand-horvath there are two months to test and fix |
Hope we see latest chromium soon! VSCODE insiders atleast should have
latest version, given it's name
[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&>
06/13/23,
11:18:34 AM
…On Tue, Jun 13, 2023 at 3:22 AM 余腾靖 ***@***.***> wrote:
@lorand-horvath <https://github.com/lorand-horvath> there are two months
to test and fix
—
Reply to this email directly, view it on GitHub
<#184021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRXJSCBMGYFMINSVFY3XDDXK6JCDANCNFSM6AAAAAAYWPFLUU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@deepak1556 will be released in July interation? |
I agree that using blazing edge electron may get issues. But at least
VSCode Insiders should have Electron version 23 or 24 to benefit. I'm not
talking about the stable version of VSCode, but the Insider version.
…On Mon, Jul 10, 2023, 1:49 PM 余腾靖 ***@***.***> wrote:
@deepak1556 <https://github.com/deepak1556> will be released in July
interation?
—
Reply to this email directly, view it on GitHub
<#184021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRXJSGZMUMRLDHXY2AFOL3XPO62LANCNFSM6AAAAAAYWPFLUU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@fisforfaheem That's not how it works; this is the 3rd time you are asking to have Electron 24 only in Insiders. |
Ok, thanks for the clarification. Any idea how to find that exploration
builds easily
…On Mon, Jul 10, 2023, 1:58 PM Lorand Horvath ***@***.***> wrote:
I agree that using blazing edge electron may get issues. But at least
VSCode Insiders should have Electron version 23 or 24 to benefit. I'm not
talking about the stable version of VSCode, but the Insider version.
@fisforfaheem <https://github.com/fisforfaheem> That's not how it works;
this is the 3rd time you are asking to have Electron 24 only in Insiders.
Insiders is max 1 month ahead of official VSCode, you can verify that
yourself. It's basically the beta testing phase.
There's also VSCode Exploration, which is the alpha development phase.
—
Reply to this email directly, view it on GitHub
<#184021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRXJSHX7H5ZBDAS55F6FQTXPO74PANCNFSM6AAAAAAYWPFLUU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@fisforfaheem You can find VSCode Exploration version 1.75 here: |
@tjx666 not likely, this iteration will be focused on resolving the two Node.js blockers
|
It works very well! Thank you very much! |
https://github.com/electron/electron/releases/tag/v26.0.0 |
@deepak1556 any performance improved after upgrade electron v25? I think node18 maybe improve some |
yes feeling a slight performance improvement
…On Tue, Aug 29, 2023 at 12:09 PM 余腾靖 ***@***.***> wrote:
@deepak1556 <https://github.com/deepak1556> any performance improved
after upgrade electron v25? I think node18 maybe improve some
—
Reply to this email directly, view it on GitHub
<#184021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRXJSDCAI5DYEENARRWKGLXXWIQ5ANCNFSM6AAAAAAYWPFLUU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
https://github.com/electron/electron/releases/tag/v26.1.0 |
@tjx666 yes we have seen nice improvements to render process launch times across all platforms, most noticeable on windows with ~80ms drop, there are also some minor script execution time improvements ~20-30ms. However on macOS we lost some time from start till |
Just FYI, the following bug is present in Electron 25 and therefore present in the latest release of VS Code: electron/electron#38790 I realize there are probably other bugs in Electron 25 that would be present in VS Code but I ran into this one and I had to figure out if it was VS Code or electron that was the issue. |
I will now venture and say (without trying to blame anyone) that the update to Electron 25 was rushed in VSCode 1.82, as I've correctly predicted would happen #184021 (comment) - that strange bugs were going to creep in. I'd really like to have an Electron 22 branch build of VSCode still available and maintained, it was much more stable, no serious issues as far as I can see. And it was also working on Windows 7 without problems. But that's too much to ask, I guess. |
This comment was marked as spam.
This comment was marked as spam.
My comment about the bug from Electron 25 being in VS Code was not to disparage the work to do the upgrade or suggest that it should not have been done. I merely wanted to point it out in case anyone else ran into it. It is a very strange bug but not show stopping. Having said that, I think this just reiterates that the work to keep VS Code inline with Electron upgrades (including any bug fixes) is important and should be as streamlined as possible. Other than this bug, being able to now run and test my WebGPU based code directly inside VS Code has been invaluable. |
Todo
The text was updated successfully, but these errors were encountered: