Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update builds for [email protected] #189089

Merged
merged 1 commit into from
Jul 27, 2023
Merged

chore: update builds for [email protected] #189089

merged 1 commit into from
Jul 27, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 27, 2023

No description provided.

@alexr00 alexr00 self-assigned this Jul 27, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) July 27, 2023 19:05
@joaomoreno joaomoreno added this to the June 2023 Recovery 2 milestone Jul 27, 2023
@joaomoreno joaomoreno added the candidate Issue identified as probable candidate for fixing in the next release label Jul 27, 2023
@joaomoreno joaomoreno merged commit 2ccd690 into release/1.80 Jul 27, 2023
@joaomoreno joaomoreno deleted the alexr00/profitable-echidna branch July 27, 2023 19:26
@levrik
Copy link

levrik commented Jul 28, 2023

It's cool that this PR is linked from the release notes but it's not very helpful without context 😅

@zhouxinghong
Copy link

Hello! Whether to consider updating electron to electron version 25+

@swarnava
Copy link

Hello! Whether to consider updating electron to electron version 25+

#184021

@jsphstls
Copy link

I am also curious about the context. @playwright/[email protected] was able to successfully launch the electron application of version 1.80.1 on a darwin/arm64 runner, yet version 1.80.2 fails to launch.

@Mogga-hub
Copy link

I am also curious about the context. @playwright/[email protected] was able to successfully launch the electron application of version 1.80.1 on a darwin/arm64 runner, yet version 1.80.2 fails to launch.

@TECHSYS1999
Copy link

It's cool that this PR is linked from the release notes but it's not very helpful without context 😅

@swarnava
Copy link

It means they are already working on this and being tested on Insider bill,

To answer your question, yes they are considering upgrading to electron 25

Roberteclick555
Roberteclick555 suggested changes Jul 30, 2023
View reviewed changes
Copy link

@Roberteclick555 Roberteclick555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

@Thilksoe
Copy link

hello

@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
@alexdima
Copy link
Member

alexdima commented Sep 15, 2023 •
edited
Loading

We had an embargo from the Electron team which was only lifted last week. For full transparency, this is the reason we updated Electron on Jul 27th with 1.80.2 -- #192902

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roberteclick555 Roberteclick555 Roberteclick555 requested changes

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@alexr00 alexr00

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
June 2023 Recovery 2
Development

Successfully merging this pull request may close these issues.