Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are terminal word link hovers too aggressive? #95080

Closed
Tyriar opened this issue Apr 13, 2020 · 1 comment · Fixed by #95608
Closed

Are terminal word link hovers too aggressive? #95080

Tyriar opened this issue Apr 13, 2020 · 1 comment · Fixed by #95608
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links ux User experience issues verified Verification succeeded
Milestone
April 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2020 •
edited
Loading

If everything in the terminal can be a link will the tooltip get annoying?

One idea is to only show underlines and tooltips when ctrl/cmd is not down when the match is "high quality" (web or validated local).
@Tyriar Tyriar added ux User experience issues terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach terminal-links labels Apr 13, 2020
@Tyriar Tyriar added this to the On Deck milestone Apr 13, 2020
@Tyriar Tyriar self-assigned this Apr 13, 2020
@Tyriar Tyriar mentioned this issue Apr 13, 2020
Closed
14 tasks
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 18, 2020
@Tyriar
Allow hiding of link underlines
48f5799 
See microsoft/vscode#95080
@Tyriar Tyriar mentioned this issue Apr 18, 2020
Merged
@Tyriar Tyriar modified the milestones: On Deck, April 2020 Apr 18, 2020
@Tyriar Tyriar mentioned this issue Apr 19, 2020
Merged
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 27, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2020

To verify ensure that "search workspace" links do not show underlines when mousing over them.

@mjbvz mjbvz added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Terminal link hover improvements microsoft/vscode
2 participants
@Tyriar @mjbvz