-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal link provider-based links preview #95081
Comments
This also no longer dismisses the hover when terminal output occurs, this was over zealous anyway. The actual bug it was trying to fix it tracked in #95081
Great stuff! Will it navigation via the keyboard? This might be overkill, but the ability to use something like jumpy (https://github.com/wmaurer/vscode-jumpy) to follow links would be nice. |
@kelleyma49 currently not, but xtermjs/xterm.js#2848 could make it easier to do that. It would be cool to be able to navigate to the most recently output link and before that, definitely something that should be considered before it's no longer a preview. Created #95570 For jumpy support it would need a whole bunch of APIs which don't exist so that's out of scope but may be possible one day. |
Agreed! Thanks for creating the new issue. Subscribed! |
Closing off for April, May's work is tracked in #96266 |
You can try out this feature in Insiders by enabling this setting:
The link provider experimental API in xterm.js has been merged in with xtermjs/xterm.js#2530 and adopted in VS Code with #90336. I improved it further by adding validated local links (closes the gap with the old system) and "word" links which is the fallback that created words links based on the
wordSeparators
setting that open quick access.This issue tracks removal of the old link matcher code, promoting the link provider to default and cleaning up the rough edges.
The plan for April is to get this in a reasonable/preview state, which is already is pretty much. Then for May polish and invest in exposing an API to extensions #91290
The text was updated successfully, but these errors were encountered: