Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal links should dismiss when their line content changes #95556

Closed
Tyriar opened this issue Apr 17, 2020 · 2 comments
Closed

Terminal links should dismiss when their line content changes #95556

Tyriar opened this issue Apr 17, 2020 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
May 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 17, 2020

Repro

  1. Click the terminal to focus it
  2. Hover a link
  3. Press enter until the link position moves, it should dismiss when the text underneath no longer exists

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links labels Apr 17, 2020
@Tyriar Tyriar added this to the May 2020 milestone Apr 17, 2020
@Tyriar Tyriar self-assigned this Apr 17, 2020
@Tyriar Tyriar mentioned this issue Apr 17, 2020
Closed
14 tasks
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 25, 2020
@Tyriar
Invalidate all links above when the terminal scrolls
22aaf04 
See microsoft/vscode#95556
@Tyriar Tyriar modified the milestones: May 2020, April 2020 Apr 25, 2020
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 25, 2020
@Tyriar Tyriar mentioned this issue Apr 25, 2020
Merged
@Tyriar Tyriar closed this as completed in 2c76881 Apr 26, 2020
@Tyriar Tyriar added upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Apr 26, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 30, 2020
@connor4312
Copy link
Member

I still see this in today's insiders:

@connor4312 connor4312 reopened this Apr 30, 2020
@connor4312 connor4312 added verification-found Issue verification failed and removed verified Verification succeeded labels Apr 30, 2020
@Tyriar Tyriar modified the milestones: April 2020, May 2020 Apr 30, 2020
@Tyriar Tyriar removed the verification-found Issue verification failed label Apr 30, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 30, 2020

I think my xterm update didn't work, or I forgot to do it 🤔 There was another bug that was meant to be fixed that wasn't too.

@Tyriar Tyriar closed this as completed in faf7a4e May 5, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
[email protected] [email protected]
d013476 
Diff: xtermjs/xterm.js@e7f72a1...51dc03a

Fixes microsoft#95556
Fixes microsoft#86072
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
3 participants
@Tyriar @connor4312 @RMacfarlane