Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link hovers sometimes stick around when mouse is out #95997

Closed
Tyriar opened this issue Apr 23, 2020 · 2 comments
Closed

Link hovers sometimes stick around when mouse is out #95997

Tyriar opened this issue Apr 23, 2020 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links verified Verification succeeded
Milestone
May 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 23, 2020

I see this most of the time when alt+tabbing back to old windows, I have seen it by sweeping the mouse into the terminal and into the editor space though. Some mouseleave event isn't firing
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 23, 2020
@Tyriar Tyriar added this to the May 2020 milestone Apr 23, 2020
@Tyriar Tyriar self-assigned this Apr 23, 2020
This was referenced Apr 23, 2020
Closed
Closed
This was referenced May 6, 2020
Closed
Closed
@Tyriar
Copy link
Member Author

Tyriar commented May 6, 2020

Repro:

  1. Print a bunch of file/folder links on successive lines (tooltip should say open folder or file)
  2. Move the mouse up and slightly diagonally and pause
  3. Move the mouse down and slightly diagonally and pause, until the tooltip sticks.

81174063-fd20d180-8f55-11ea-87e2-33d197de3eb2

The bug is a result of the hover event firing for the same row but different columns before the link provider has resolved. More details: xtermjs/xterm.js#2913

@Tyriar Tyriar closed this as completed in 6f5f899 May 6, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2020

Used to see this all the time, but haven't for a long time now.

@Tyriar Tyriar added the verified Verification succeeded label Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
[email protected]
90a97fa 
Diff: xtermjs/xterm.js@7ab0a42...f9adf8a

Fixes microsoft#95997
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
1 participant
@Tyriar