chakrashim: ref count data sent to SetEmbedderData

JS Objects passed to SetEmbedderData need to have JsAddRef/JsRelease called, otherwise they could be GC'd prematurely. Fixes: nodejs#97 PR-URL: nodejs#374 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
mike-kaufman · Aug 21, 2017 · 5e01643 · 5e01643
1 parent fd0d4a3
commit 5e01643
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/deps/chakrashim/src/jsrtcontextshim.cc b/deps/chakrashim/src/jsrtcontextshim.cc
@@ -471,6 +471,15 @@ void ContextShim::SetAlignedPointerInEmbedderData(int index, void * value) {
     if (embedderData.size() < minSize) {
       embedderData.resize(minSize);
     }
+
+    // ensure reference counting, otherwise objects can be GC'd.  JsAddRef/
+    // JsRelease will handle cases if the pointer is not valid for ref counts.
+    void * oldValue = embedderData[index];
+    if (oldValue != nullptr) {
+      JsRelease(oldValue, nullptr);
+    }
+    JsAddRef(value, nullptr);
+
     embedderData[index] = value;
   } catch(const std::exception&) {
   }