This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
SetEmbedderData doesn't pin the data #97
Assignees
Comments
mike-kaufman
pushed a commit
to mike-kaufman/node-chakracore
that referenced
this issue
Aug 18, 2017
JS Objects passed to SetEmbedderData need to have JsAddRef/JsRelease called, otherwise they could be GC'd prematurely. Fixes: nodejs#97
3 tasks
mike-kaufman
pushed a commit
to mike-kaufman/node-chakracore
that referenced
this issue
Aug 21, 2017
JS Objects passed to SetEmbedderData need to have JsAddRef/JsRelease called, otherwise they could be GC'd prematurely. Fixes: nodejs#97 PR-URL: nodejs#374 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
MSLaguana
pushed a commit
to MSLaguana/node-chakracore
that referenced
this issue
Sep 25, 2017
JS Objects passed to SetEmbedderData need to have JsAddRef/JsRelease called, otherwise they could be GC'd prematurely. Fixes: nodejs#97 PR-URL: nodejs#374 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
SetEmbedderData()can be used to setJsValueRef. Currently we don't pin the objects and it could get collected prematurely. Fix it by callingJsAddRefthe value if value isJsValueRef.The text was updated successfully, but these errors were encountered: