-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python3 package location #67
base: master
Are you sure you want to change the base?
Conversation
urlparse has been moved to be inside urllib.parse in python3. This commit should fix this dependency.
Having this library python3 compatible will be reliant on what the author choses to do with python-oauth. The necessity of this pull request will be decided by #66 |
Fix python3 package location
Fixes python3 issue for me! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative compatibility check would be if 'python2' in urllib.__file__:
, but I can't say if that has any performance impact. This solution looks a little cleaner.
@loleg ready for merge |
Anything blocking this from being merged? |
Most likely #94 |
urlparse has been moved to be inside urllib.parse in python3. This commit should fix this dependency.