Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3 package location #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaitaiwan
Copy link

urlparse has been moved to be inside urllib.parse in python3. This commit should fix this dependency.

urlparse has been moved to be inside urllib.parse in python3. This commit should fix this dependency.
@jaitaiwan
Copy link
Author

Having this library python3 compatible will be reliant on what the author choses to do with python-oauth. The necessity of this pull request will be decided by #66

gnunicorn added a commit to gnunicorn/flask-oauth that referenced this pull request Sep 13, 2015
@PierrePaul
Copy link

Fixes python3 issue for me! Thanks!

Copy link

@loleg loleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative compatibility check would be if 'python2' in urllib.__file__:, but I can't say if that has any performance impact. This solution looks a little cleaner.

@jaitaiwan
Copy link
Author

@loleg ready for merge

@simonv3
Copy link

simonv3 commented Jun 20, 2018

Anything blocking this from being merged?

@loleg
Copy link

loleg commented Jun 22, 2018

Most likely #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants