Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urljoin #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Urljoin #77

wants to merge 2 commits into from

Conversation

hammygoonan
Copy link

I've added a check for the Python version before importing urljoin as the import is different for Python 2 and 3.

@tcyrus
Copy link

tcyrus commented Apr 28, 2016

Duplicate of #67

jansedlon
jansedlon suggested changes Dec 28, 2017
View reviewed changes
Copy link

@jansedlon jansedlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about to use try except ImportError?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansedlon jansedlon jansedlon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hammygoonan @tcyrus @jansedlon