Code clean-up: class-methods-use-this #1312
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some violations of eslint rule
class-methods-use-this
which were suppressed.isAbsoluteUrl
andgetModelPath
utilities frommodelLoader
instead of duplicating them in multiple classes.eslint-disable
which was not actually needed.||
instead of class methodcheckUndefined
to set defaults inFaceApi
. I wanted to use the nullish coalescing??
but the eslint version is too outdated to support it!The FaceApi code could be cleaned up further with object spreading, but the behavior would differ slightly if the user explicitly provides a falsey value. It could be reduced to: