Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run in Node.js we must guard all
window
references withtypeof window !== 'undefined'
before accessing thewindow
variable. Otherwise it throws a fatal errorReferenceError: window is not defined
as reported in issue #1317.This PR addresses all uses of
window
in the/src
directory:window.location.pathname
in themodelLoader
utility and removes it from theFaceApi
class.Color
class throughp5Utils.p5Instance.Color
insteadwindow.p5.Color
inBodyPix
. (Note: this was previously guarded byp5Utils.checkP5
, so it would only cause an error if the user was using p5 in Node).window
in theP5Util
constructor. There was already a guard in theP5Util.p5Instance
getter, but I believe that is too late as the error will have already been thrown in the constructor.There will be additional changes needed to run in Node.js, such as guarding classes
HTMLImageElement
, etc.