feat:implement responsive learn-more section #34
Conversation
| line-height: 22px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (min-width: 769px) and (max-width: 1024px) { |
There was a problem hiding this comment.
You don't need the and (max-width: ... ) in my opinion
| @@ -3,6 +3,13 @@ | |||
| line-height: 19px; | |||
| } | |||
|
|
|||
| @media only screen and (max-width: 320px) { | |||
There was a problem hiding this comment.
I don't have where to write it but, the additional title in 320px screen is 28px and should be 20px.
Also, why in additional info the title block is unique to additional info? why not use content title?
| @@ -15,5 +15,6 @@ | |||
| .additional-info__subtitle { | |||
| font-size: 18px; | |||
| line-height: 18px; | |||
| margin: 22px 0 0; | |||
There was a problem hiding this comment.
In 320px screen the size of the subtitle is 12px
There was a problem hiding this comment.
switched to content_subtitle
blocks/arrow-icon/arrow-icon.css
Outdated
|
|
||
| @media only screen and (max-width: 320px) { | ||
| .arrow-icon { | ||
| font-size: 14px; |
There was a problem hiding this comment.
The icon of the arrow is aligned to the upper row of the link and not the lower row
| .arrow-icon { | ||
| font-size: 14px; | ||
| width: 26px; | ||
| height: 22px; |
There was a problem hiding this comment.
The arrow is too big compared to the figma design
| @@ -1,11 +1,11 @@ | |||
| .additional-info__list-item { | |||
| margin-bottom: 20px; | |||
| margin-bottom: 16px; | |||
There was a problem hiding this comment.
You should add "last-of-type", you have extra margin on the second list item
| @@ -1,11 +1,11 @@ | |||
| .additional-info__list-item { | |||
| margin-bottom: 20px; | |||
| margin-bottom: 16px; | |||
There was a problem hiding this comment.
margin bottom should be 18px for 320px
| @@ -3,6 +3,13 @@ | |||
| line-height: 19px; | |||
| } | |||
|
|
|||
| @media only screen and (max-width: 320px) { | |||
| .additional-info__link { | |||
| font-size: 14px; | |||
There was a problem hiding this comment.
You should specify font-weight everywhere. font-weight 500 looks different the the normal one.
No description provided.