feat:implement responsive learn-more section #34
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| .additional-info__list-item { | ||
| margin-bottom: 16px; | ||
|
There was a problem hiding this comment. You should add "last-of-type", you have extra margin on the second list item There was a problem hiding this comment. margin bottom should be 18px for 320px |
||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
|
|
||
| } | ||
|
|
||
| .additional-info__list-item:last-of-type { | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| @media only screen and (min-width: 425px) and (max-width: 768px) { | ||
| .additional-info__list-item { | ||
| margin-bottom: 20px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (max-width: 424px) { | ||
| .additional-info__list-item { | ||
| margin-bottom: 18px; | ||
| align-items: flex-end; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,20 @@ | ||
| .additional-info__list { | ||
| margin: 0; | ||
| list-style-type: none; | ||
| padding: 0; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 320px) { | ||
| .additional-info__list { | ||
| margin: 0; | ||
| padding-top:10px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (min-width: 769px) and (max-width: 1024px) { | ||
| .additional-info__list { | ||
| margin: 0; | ||
| padding-top: 4px; | ||
| } | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,40 @@ | ||
| @import url(./__list/additional-info__list.css); | ||
| @import url(./__list-item/additional-info__list-item.css); | ||
| @import url(./__link/additional-info__link.css); | ||
|
|
||
| .additional-info { | ||
| border-bottom: 1.7px solid #223d46; | ||
| padding: 68px 0 40px; | ||
| margin: 0 30px; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 320px) { | ||
| .additional-info { | ||
| margin: 0 16px 0; | ||
| padding: 50px 0 30px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (min-width: 769px) and (max-width: 1024px) { | ||
| .additional-info { | ||
| padding: 84px 0 50px; | ||
| margin: 0 40px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (min-width: 1025px) { | ||
| .additional-info { | ||
| padding: 100px 0 60px; | ||
| max-width: 1200px; | ||
| margin: 0 40px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (min-width: 1280px) { | ||
| .additional-info { | ||
| margin: 0 auto; | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,40 @@ | ||
| .arrow-icon { | ||
| width: 43px; | ||
| height: 19px; | ||
| background: url("./blue-arrow.png") center right no-repeat; | ||
| background-size: 11px 11px; | ||
| } | ||
|
|
||
| .arrow-icon:hover { | ||
| background: url("./yellow-arrow.png") center right no-repeat; | ||
| background-size: 11px 11px; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 320px) { | ||
| .arrow-icon { | ||
| width: 26px; | ||
| height: 22px; | ||
|
There was a problem hiding this comment. The arrow is too big compared to the figma design |
||
| background-size: 8px 8px; | ||
| } | ||
|
|
||
| .arrow-icon:hover { | ||
| width: 26px; | ||
| height: 22px; | ||
| background-size: 8px 8px; | ||
| } | ||
| } | ||
|
|
||
| @media only screen and (min-width: 1280px) { | ||
| .arrow-icon { | ||
| width: 61px; | ||
| height: 39px; | ||
| background-size: 16px 16px; | ||
| } | ||
|
|
||
| .arrow-icon:hover { | ||
| width: 61px; | ||
| height: 39px; | ||
| background-size: 16px 16px; | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have where to write it but, the additional title in 320px screen is 28px and should be 20px.
Also, why in additional info the title block is unique to additional info? why not use content title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched