avoid creating many Annotations objects in for loop #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 24 24
Lines 3847 3847
=======================================
Hits 3662 3662
Misses 185 185
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@agramfort Care to add a short changelog entry? |
|
Thanks @agramfort! |
sappelhoff
pushed a commit
to sappelhoff/mne-bids
that referenced
this pull request
Oct 21, 2022
sappelhoff
added a commit
that referenced
this pull request
Oct 21, 2022
* avoid creating many Annotations objects in for loop (#1079) * ENH: Better error message (#1080) * ENH: Better error message * FIX: Beautiful infrastructure * FIX: Spacing * ENH: Improve error message (#1081) * ENH: Improve error message * FIX: Use working openneuro-py * FIX: Install * FIX: Name * ENH: Make suggestion (#1087) * MRG: Enforce specification of all annotation descriptions in event_id if event_id is passed to write_raw_bids() (#1086) * Write all annotations even if event_id was passed * Implement new logic * Update changelog * Fix tests * Style * REL: v0.11.1 Co-authored-by: Alexandre Gramfort <[email protected]> Co-authored-by: Eric Larson <[email protected]> Co-authored-by: Richard Höchenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this fix read_raw_bids on a subject from https://openneuro.org/datasets/ds003825 takes 600s on my laptop. With this fix it's < 3s.