-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump conda-incubator/setup-miniconda from 2 to 3 #12260
Bump conda-incubator/setup-miniconda from 2 to 3 #12260
Conversation
Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from 2 to 3. - [Release notes](https://github.com/conda-incubator/setup-miniconda/releases) - [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/main/CHANGELOG.md) - [Commits](conda-incubator/setup-miniconda@v2...v3) --- updated-dependencies: - dependency-name: conda-incubator/setup-miniconda dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Doc builds would have failed until fatiando/pooch#379 is resolved, but given how deep in our code these |
@@ -4532,7 +4532,7 @@ def _reflow_param_docstring(docstring, has_first_line=True, width=75): | |||
theme : str | path-like | |||
Can be "auto", "light", or "dark" or a path-like to a | |||
custom stylesheet. For Dark-Mode and automatic Dark-Mode-Detection, | |||
:mod:`qdarkstyle` and | |||
`qdarkstyle <https://github.com/ColinDuquesnoy/QDarkStyleSheet>`__ and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the argument for dropping niche dependencies from intersphinx, but FWIW I also worry that hard-coded URLs like this will need to change eventually (eg. if QDarkStyleSheet repo ownership is transferred to an org or whatever). I guess it's a question of how frequent the annoyance is likely to be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I also worry that hard-coded URLs like this will need to change eventually
We have the same issue with intersphinx URLs, too -- people can change where their docs are hosted, and that does happen from time to time. At least when repos are moved, GitHub mirrors / redirects repo moves to the new location I think. So hopefully this is actually an improvement in that regard! And we have monthly linkcheck
to check it for us which is probably good enough.
3b9676b
to
b2ced04
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eric Larson <[email protected]>
Bumps conda-incubator/setup-miniconda from 2 to 3.
Release notes
Sourced from conda-incubator/setup-miniconda's releases.
... (truncated)
Changelog
Sourced from conda-incubator/setup-miniconda's changelog.
... (truncated)
Commits
11b5629
Prepare 3.0.1 (#326)8706aa7
Fix env activation on win (a v3 regression) due to hard-coded install PATH (#...c585a97
Bump conda-incubator/setup-miniconda from 2.3.0 to 3.0.0 (#321)2defc80
Prepare release (#320)0d5a56b
Bump actions/checkout from 2 to 4 (#319)45fd3f9
Merge pull request #316 from dbast/timeoutd1e04fc
Merge pull request #299 from isuruf/condaBasePathfab0073
Merge pull request #318 from dbast/readmefa6bdf9
Update with npm run buildd42f8b8
Fix condaBasePath when useBundled is false, and there's no pre-existing condaDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)