Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump conda-incubator/setup-miniconda from 2 to 3 #12260

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Bumps conda-incubator/setup-miniconda from 2 to 3.

Release notes

Sourced from conda-incubator/setup-miniconda's releases.

Version 3.0.0

Features

  • #308 Update to node20
  • #291 Add conda-solver option (defaults to libmamba)

Fixes

  • #299 Fix condaBasePath when useBundled is false, and there's no pre-existing conda

Documentation

  • #309 Switch to main branch based development
  • #313 Specify team conda-incubator/setup-miniconda as codeowners
  • #318 README: update actions in examples, add security section, similar actions

Tasks and Maintenance

  • #307 Run dependabot against main branch and also update node packages
  • #311 Bump actions/checkout from 2 to 4
  • #310 Bump actions/cache from 1 to 3
  • #314 Strip/update dependencies
  • #315 Split lint into check and build, switch from npm install to npm ci
  • #317 Bump normalize-url from 4.5.1 to 8.0.0
  • #316 Faster workflow response / saving resources via timeout/concurrency policy

#308: conda-incubator/setup-miniconda#308 #291: conda-incubator/setup-miniconda#291 #299: conda-incubator/setup-miniconda#299 #309: conda-incubator/setup-miniconda#309 #313: conda-incubator/setup-miniconda#313 #318: conda-incubator/setup-miniconda#318 #307: conda-incubator/setup-miniconda#307 #311: conda-incubator/setup-miniconda#311 #310: conda-incubator/setup-miniconda#310 #314: conda-incubator/setup-miniconda#314 #315: conda-incubator/setup-miniconda#315 #317: conda-incubator/setup-miniconda#317 #316: conda-incubator/setup-miniconda#316

New Contributors

Full Changelog: conda-incubator/setup-miniconda@v2...v3.0.0

Version 2.3.0

Documentation

  • #263 Update links to GitHub shell docs

... (truncated)

Changelog

Sourced from conda-incubator/setup-miniconda's changelog.

v3.0.1 (2023-11-29)

Fixes

  • #325 Fix environment activation on windows (a v3 regression) due to hard-coded install PATH

#325: conda-incubator/setup-miniconda#325

v3.0.0 (2023-11-27)

Features

  • #308 Update to node20
  • #291 Add conda-solver option (defaults to libmamba)

Fixes

  • #299 Fix condaBasePath when useBundled is false, and there's no pre-existing conda

Documentation

  • #309 Switch to main branch based development
  • #313 Specify team conda-incubator/setup-miniconda as codeowners
  • #318 README: update actions in examples, add security section, similar actions

Tasks and Maintenance

  • #307 Run dependabot against main branch and also update node packages
  • #311 Bump actions/checkout from 2 to 4
  • #310 Bump actions/cache from 1 to 3
  • #314 Strip/update dependencies
  • #315 Split lint into check and build, switch from npm install to npm ci
  • #317 Bump normalize-url from 4.5.1 to 8.0.0
  • #316 Faster workflow response / saving resources via timeout/concurrency policy

#308: conda-incubator/setup-miniconda#308 #291: conda-incubator/setup-miniconda#291 #299: conda-incubator/setup-miniconda#299 #309: conda-incubator/setup-miniconda#309 #313: conda-incubator/setup-miniconda#313 #318: conda-incubator/setup-miniconda#318 #307: conda-incubator/setup-miniconda#307 #311: conda-incubator/setup-miniconda#311 #310: conda-incubator/setup-miniconda#310

... (truncated)

Commits
  • 11b5629 Prepare 3.0.1 (#326)
  • 8706aa7 Fix env activation on win (a v3 regression) due to hard-coded install PATH (#...
  • c585a97 Bump conda-incubator/setup-miniconda from 2.3.0 to 3.0.0 (#321)
  • 2defc80 Prepare release (#320)
  • 0d5a56b Bump actions/checkout from 2 to 4 (#319)
  • 45fd3f9 Merge pull request #316 from dbast/timeout
  • d1e04fc Merge pull request #299 from isuruf/condaBasePath
  • fab0073 Merge pull request #318 from dbast/readme
  • fa6bdf9 Update with npm run build
  • d42f8b8 Fix condaBasePath when useBundled is false, and there's no pre-existing conda
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from 2 to 3.
- [Release notes](https://github.com/conda-incubator/setup-miniconda/releases)
- [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/main/CHANGELOG.md)
- [Commits](conda-incubator/setup-miniconda@v2...v3)

---
updated-dependencies:
- dependency-name: conda-incubator/setup-miniconda
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from larsoner as a code owner December 4, 2023 09:16
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 4, 2023
@larsoner larsoner requested a review from drammock as a code owner December 4, 2023 16:36
@larsoner
Copy link
Member

larsoner commented Dec 4, 2023

Doc builds would have failed until fatiando/pooch#379 is resolved, but given how deep in our code these pooch.* refs are and how expert an option it is, I just decided to get rid of the intersphinx ref. Our builds fail every once in a while due to some of these failing to fetch so it's probably only worth having them if it's really going to help a lot of users having the quick HTML link accessible.

@larsoner larsoner enabled auto-merge (squash) December 4, 2023 17:46
@@ -4532,7 +4532,7 @@ def _reflow_param_docstring(docstring, has_first_line=True, width=75):
theme : str | path-like
Can be "auto", "light", or "dark" or a path-like to a
custom stylesheet. For Dark-Mode and automatic Dark-Mode-Detection,
:mod:`qdarkstyle` and
`qdarkstyle <https://github.com/ColinDuquesnoy/QDarkStyleSheet>`__ and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the argument for dropping niche dependencies from intersphinx, but FWIW I also worry that hard-coded URLs like this will need to change eventually (eg. if QDarkStyleSheet repo ownership is transferred to an org or whatever). I guess it's a question of how frequent the annoyance is likely to be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I also worry that hard-coded URLs like this will need to change eventually

We have the same issue with intersphinx URLs, too -- people can change where their docs are hosted, and that does happen from time to time. At least when repos are moved, GitHub mirrors / redirects repo moves to the new location I think. So hopefully this is actually an improvement in that regard! And we have monthly linkcheck to check it for us which is probably good enough.

@larsoner larsoner force-pushed the dependabot/github_actions/conda-incubator/setup-miniconda-3 branch from 3b9676b to b2ced04 Compare December 4, 2023 18:57
@larsoner larsoner merged commit 82d195d into main Dec 4, 2023
27 checks passed
@larsoner larsoner deleted the dependabot/github_actions/conda-incubator/setup-miniconda-3 branch December 4, 2023 22:26
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eric Larson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants