-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Make selenium optional and use on CircleCI #12263
Conversation
Will fail until #12260 lands but local builds now show this instead of the contributor image: |
Co-authored-by: Daniel McCloy <[email protected]>
Thanks @larsoner ! I also tried running a full |
Up to date pyvista and pyvistaqt? I think having the pattern working is enough for this PR at least. But we can continue to discuss here or in a separate issue the full build error. Or just not worry about it since in practice Circle is the only one who needs to suffer through full builds :) |
* upstream/main: MRG: Use ruff-format instead of Black (mne-tools#12261) MAINT: Make selenium optional and use on CircleCI (mne-tools#12263) MAINT: Post-release deprecations (mne-tools#12265) MAINT: Replace `Path.parent.parent` with `Path.parents[N]` in tests (mne-tools#12257)
Yup, fresh conda install (pyvista |
Co-authored-by: Daniel McCloy <[email protected]>
See title, should make it easier to build our docs. @britta-wstnr can you try building docs on this branch and see if it works? I made the avatar image gen opt-in (and opted CircleCI in) rather than opt-out so you should just be able to check out my branch, and run
make clean
thenmake html
and see if it succeeds. I think we should iterate until things work for you to improve our odds of other contributors being able to build docs.