Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Make selenium optional and use on CircleCI #12263

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Dec 4, 2023

See title, should make it easier to build our docs. @britta-wstnr can you try building docs on this branch and see if it works? I made the avatar image gen opt-in (and opted CircleCI in) rather than opt-out so you should just be able to check out my branch, and run make clean then make html and see if it succeeds. I think we should iterate until things work for you to improve our odds of other contributors being able to build docs.

@larsoner larsoner added this to the 1.7 milestone Dec 4, 2023
@larsoner
Copy link
Member Author

larsoner commented Dec 4, 2023

Will fail until #12260 lands but local builds now show this instead of the contributor image:

Screenshot from 2023-12-04 13-20-06

doc/sphinxext/contrib_avatars.py Outdated Show resolved Hide resolved
@britta-wstnr
Copy link
Member

Thanks @larsoner !
Running make html-pattern ... works for me again ! 🎉

I also tried running a full make html but this throws a memory error for me (at 35_dipole_orientations.py, which ultimately results in pyvista.plotting.errors.RenderWindowUnavailable: Render window is not current.and then sphinx.errors.ExtensionError: Handler <function generate_gallery_rst at 0x16997afc0> for event 'builder-inited' threw an exception (exception: [<mne.viz._brain._brain.Brain object at 0x2a8f0e510>])).
This surprises me a bit, as I have 16 GB RAM. I will try again tonight after closing everything else down.

@larsoner
Copy link
Member Author

larsoner commented Dec 5, 2023

Up to date pyvista and pyvistaqt?

I think having the pattern working is enough for this PR at least. But we can continue to discuss here or in a separate issue the full build error. Or just not worry about it since in practice Circle is the only one who needs to suffer through full builds :)

@larsoner larsoner merged commit 092cf90 into mne-tools:main Dec 5, 2023
27 checks passed
@larsoner larsoner deleted the selenium branch December 5, 2023 15:31
larsoner added a commit to hoechenberger/mne-python that referenced this pull request Dec 5, 2023
* upstream/main:
  MRG: Use ruff-format instead of Black (mne-tools#12261)
  MAINT: Make selenium optional and use on CircleCI (mne-tools#12263)
  MAINT: Post-release deprecations (mne-tools#12265)
  MAINT: Replace `Path.parent.parent` with `Path.parents[N]` in tests (mne-tools#12257)
@britta-wstnr
Copy link
Member

Up to date pyvista and pyvistaqt?

Yup, fresh conda install (pyvista 0.42.3 and pyvistaqt 0.11.0)
But indeed, I don't run full builds - so fine for me to not look further into. I just found it puzzling!

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants