Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dashboard under developer documentation #715

Merged
merged 6 commits into from
Dec 29, 2021

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Dec 28, 2021

Description of changes:

Renames dashboard to bookrunner (and "book runner" in general). Moves all documentation (including HTML & text results) under developer documentation. Any scripts or documentation now refer to book runner instead.

Resolved issues:

Resolves #698

Call-outs:

Testing:

  • How is this change tested? Regression + run command.

  • Is this a refactor change? Yes.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Let me know when you fix the regression so I can approve it. Cheers!

@adpaco-aws
Copy link
Contributor Author

Added updates to remaining materials (docs, scripts) to this PR. Ubuntu 20.04 regression shows the same results as before, so I think this is ready.

@celinval can you take a look?

@adpaco-aws adpaco-aws marked this pull request as ready for review December 29, 2021 19:10
@adpaco-aws adpaco-aws requested a review from a team as a code owner December 29, 2021 19:10
@adpaco-aws adpaco-aws merged commit c686f61 into model-checking:main Dec 29, 2021
@adpaco-aws adpaco-aws deleted the dash-move branch December 29, 2021 22:35
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 22, 2022
* Rename - Works as usual

* Changes in `build-docs.sh`

* Changes to docs

* Update workflow

* Update remaining refs to dashboard
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 25, 2022
* Rename - Works as usual

* Changes in `build-docs.sh`

* Changes to docs

* Update workflow

* Update remaining refs to dashboard
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* Rename - Works as usual

* Changes in `build-docs.sh`

* Changes to docs

* Update workflow

* Update remaining refs to dashboard
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* Rename - Works as usual

* Changes in `build-docs.sh`

* Changes to docs

* Update workflow

* Update remaining refs to dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename and move dashboard to developer documentation
3 participants