Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Windows batch file %BASEDIR% path generation #85

Closed
adamretter opened this issue Apr 27, 2019 · 2 comments · Fixed by #76
Closed

Improve Windows batch file %BASEDIR% path generation #85

adamretter opened this issue Apr 27, 2019 · 2 comments · Fixed by #76
Assignees
@khmarbaise @adamretter
Labels
enhancement
Milestone
2.1.0

Comments

@adamretter
Copy link
Contributor

Paths generated for the Windows batch scripts when expanded at runtime often include .. and \\.

This is due to the way the location of the directory containing the script is calculated and then how paths are concatenated with this.

This should be improved so that the path is correct and does not need further normalization.
@adamretter adamretter changed the title Windows paths in generates scripts include .. and \\ Windows paths in generated scripts include .. and \\ Apr 27, 2019
@adamretter adamretter changed the title Windows paths in generated scripts include .. and \\ Windows paths in generated scripts include '..' and '\\' Apr 27, 2019
@adamretter adamretter mentioned this issue Apr 27, 2019
Merged
adamretter added a commit to adamretter/appassembler that referenced this issue Apr 27, 2019
@adamretter
Improve Windows batch file %BASEDIR% path generation
eeec255 
Closes mojohaus#85
@khmarbaise
Copy link
Member

Can make consistent commit message see https://github.com/mojohaus/appassembler#contributing

@khmarbaise khmarbaise added this to the Release 3.0.0 milestone May 1, 2019
@adamretter adamretter changed the title Windows paths in generated scripts include '..' and '\\' Improve Windows batch file %BASEDIR% path generation May 1, 2019
adamretter added a commit to adamretter/appassembler that referenced this issue May 1, 2019
@adamretter
Fixes mojohaus#85 - Improve Windows batch file %BASEDIR% path generation
33a1449
@adamretter
Copy link
Contributor Author

@khmarbaise Okay done.

adamretter added a commit to adamretter/appassembler that referenced this issue May 9, 2019
@adamretter
Fixes mojohaus#85 - Improve Windows batch file %BASEDIR% path generation
6f34c3d
khmarbaise pushed a commit that referenced this issue May 9, 2019
@adamretter @khmarbaise
Fixes #85 - Improve Windows batch file %BASEDIR% path generation
c063960
@blootsvoets blootsvoets mentioned this issue May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khmarbaise khmarbaise

@adamretter adamretter

Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Improve Windows batch file %BASEDIR% path generation adamretter/appassembler
2 participants
@khmarbaise @adamretter