Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows batch file %BASEDIR% path generation #76

Merged
merged 1 commit into from
May 9, 2019

Conversation

adamretter
Copy link
Contributor

@adamretter adamretter commented Apr 18, 2019

Closes #85

This normalizes the path by resolving the .. and removing the trailing \ that was previously present.

@khmarbaise
Copy link
Member

Please rebase as well to fix build issues...

@adamretter adamretter force-pushed the hotfix/batch-file-basedir branch from 3e45bfc to eeec255 Compare April 27, 2019 15:00
@adamretter
Copy link
Contributor Author

@khmarbaise Done :-)

@adamretter adamretter force-pushed the hotfix/batch-file-basedir branch from eeec255 to 33a1449 Compare May 1, 2019 19:14
@adamretter adamretter force-pushed the hotfix/batch-file-basedir branch from 33a1449 to 6f34c3d Compare May 9, 2019 19:55
@khmarbaise khmarbaise merged commit c063960 into mojohaus:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Windows batch file %BASEDIR% path generation
2 participants