Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommandLineParser tests #174

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Add CommandLineParser tests #174

merged 1 commit into from
Mar 16, 2023

Conversation

ZKRobi
Copy link
Contributor

@ZKRobi ZKRobi commented Mar 11, 2023

Added tests for CommandLineParser
Changed WebViewOptions to handle default values by itself

@ZKRobi ZKRobi requested a review from a team March 11, 2023 09:36
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #174 (931e2df) into main (f438155) will decrease coverage by 6.06%.
The diff coverage is n/a.

❗ Current head 931e2df differs from pull request most recent head 6e4de8a. Consider uploading reports for the commit 6e4de8a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   80.11%   74.06%   -6.06%     
==========================================
  Files          82       95      +13     
  Lines        3184     3509     +325     
  Branches      135      139       +4     
==========================================
+ Hits         2551     2599      +48     
- Misses        633      910     +277     
Impacted Files Coverage Δ
src/shell/dotnet/Shell/WebWindowOptions.cs 0.00% <ø> (ø)

... and 14 files with indirect coverage changes

BalassaMarton
BalassaMarton previously approved these changes Mar 13, 2023
kruplm
kruplm previously approved these changes Mar 13, 2023
Copy link
Contributor

@kruplm kruplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ZKRobi ZKRobi merged commit 0f7969a into morganstanley:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants