Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic extensions for Message Router client #226

Merged

Conversation

BalassaMarton
Copy link
Contributor

Added the Topic extension method for obtaining an IAsyncObservable for a given topic.

@BalassaMarton BalassaMarton requested a review from a team May 30, 2023 11:10
@BalassaMarton BalassaMarton force-pushed the messagerouter-topic-observable branch from cd0e1e4 to da9e910 Compare May 30, 2023 11:35
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #226 (d48a405) into main (f193d6c) will increase coverage by 0.05%.
The diff coverage is 76.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   68.97%   69.02%   +0.05%     
==========================================
  Files         129      131       +2     
  Lines        4499     4539      +40     
  Branches      138      138              
==========================================
+ Hits         3103     3133      +30     
- Misses       1395     1405      +10     
  Partials        1        1              
Impacted Files Coverage Δ
...dotnet/src/Client/MessageRouterClientExtensions.cs 37.50% <37.50%> (ø)
...ssaging/dotnet/src/Core/MessageRouterExtensions.cs 32.25% <40.00%> (-1.81%) ⬇️
...c/messaging/dotnet/src/Core/Internal/Disposable.cs 64.28% <64.28%> (ø)
...ng/dotnet/src/Client/Client/MessageRouterClient.cs 81.67% <83.90%> (+0.89%) ⬆️

... and 1 file with indirect coverage changes

@BalassaMarton BalassaMarton force-pushed the messagerouter-topic-observable branch from da9e910 to af3a3fe Compare May 30, 2023 18:21
@BalassaMarton BalassaMarton merged commit 700ceef into morganstanley:main Jun 15, 2023
@BalassaMarton BalassaMarton deleted the messagerouter-topic-observable branch June 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants