Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic extensions for Message Router client #226

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Topic extensions for Message Router client #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af3a3fe
feature (messaging/dotnet): Added Topic extensions to the client
BalassaMarton May 30, 2023
7dc25f1
Merge branch 'main' into messagerouter-topic-observable
BalassaMarton May 31, 2023
d48a405
Merge branch 'main' into messagerouter-topic-observable
BalassaMarton Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...pe/examples/multi-module-example/ComposeUI.Example.DataService/MonthlySalesDataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@

namespace ComposeUI.Example.DataService
{
internal class MonthlySalesDataService : IDisposable
internal class MonthlySalesDataService : IAsyncDisposable
{
private readonly IMessageRouter _messageRouter;
private readonly ILogger<MonthlySalesDataService>? _logger;
private readonly List<IDisposable> _subscriptions = new();
private readonly List<IAsyncDisposable> _subscriptions = new();

public MonthlySalesDataService(IMessageRouter messageRouter, ILogger<MonthlySalesDataService>? logger = null)
{
Expand Down Expand Up @@ -84,12 +84,11 @@ private ValueTask OnSymbolSelectionError(Exception exception)
return default;
}

public void Dispose()
public ValueTask DisposeAsync()
{
foreach (var subscription in _subscriptions)
{
subscription.Dispose();
}
return new ValueTask(
Task.WhenAll(
_subscriptions.Select(x => x.DisposeAsync().AsTask())));
}

private class SymbolSelectedModel
Expand Down
Loading