-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ModuleLoader.Abstractions #373
Merged
ztanczos
merged 1 commit into
morganstanley:main
from
ztanczos:ModuleLoader.Abstractions
Oct 10, 2023
Merged
Create ModuleLoader.Abstractions #373
ztanczos
merged 1 commit into
morganstanley:main
from
ztanczos:ModuleLoader.Abstractions
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ztanczos
commented
Oct 6, 2023
- Create ModuleLoader.Abstractions package under src which expose the types required by both the Module Loader and the FDC3* related packages.
- Add unit tests
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 77.41% 77.18% -0.24%
==========================================
Files 161 164 +3
Lines 5438 5475 +37
Branches 233 233
==========================================
+ Hits 4210 4226 +16
- Misses 1227 1248 +21
Partials 1 1
|
psmulovics
previously approved these changes
Oct 8, 2023
...dule-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/IModuleCatalogue.cs
Outdated
Show resolved
Hide resolved
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/IModuleLoader.cs
Outdated
Show resolved
Hide resolved
...module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/StartupRequest.cs
Outdated
Show resolved
Hide resolved
...dule-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/IModuleCatalogue.cs
Outdated
Show resolved
Hide resolved
...module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/ModuleManifest.cs
Outdated
Show resolved
Hide resolved
...module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/StartupContext.cs
Show resolved
Hide resolved
...module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/ModuleManifest.cs
Outdated
Show resolved
Hide resolved
...module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/ModuleManifest.cs
Outdated
Show resolved
Hide resolved
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/LifetimeEvent.cs
Outdated
Show resolved
Hide resolved
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/LifetimeEvent.cs
Outdated
Show resolved
Hide resolved
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/IModuleLoader.cs
Show resolved
Hide resolved
...module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/StartupContext.cs
Outdated
Show resolved
Hide resolved
- Add unit tests for StartupContext
ztanczos
force-pushed
the
ModuleLoader.Abstractions
branch
from
October 9, 2023 14:29
6d67afd
to
f05a0b5
Compare
BalassaMarton
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.