Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ModuleLoader.Abstractions #373

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ztanczos
Copy link
Contributor

@ztanczos ztanczos commented Oct 6, 2023

  • Create ModuleLoader.Abstractions package under src which expose the types required by both the Module Loader and the FDC3* related packages.
  • Add unit tests

@ztanczos ztanczos requested a review from a team as a code owner October 6, 2023 14:24
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #373 (f05a0b5) into main (90e0865) will decrease coverage by 0.24%.
The diff coverage is 43.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   77.41%   77.18%   -0.24%     
==========================================
  Files         161      164       +3     
  Lines        5438     5475      +37     
  Branches      233      233              
==========================================
+ Hits         4210     4226      +16     
- Misses       1227     1248      +21     
  Partials        1        1              
Files Coverage Δ
...poseUI.ModuleLoader.Abstractions/StartupContext.cs 92.30% <92.30%> (ø)
...omposeUI.ModuleLoader.Abstractions/StartRequest.cs 66.66% <66.66%> (ø)
...mposeUI.ModuleLoader.Abstractions/LifetimeEvent.cs 0.00% <0.00%> (ø)

- Add unit tests for StartupContext
@ztanczos ztanczos force-pushed the ModuleLoader.Abstractions branch from 6d67afd to f05a0b5 Compare October 9, 2023 14:29
@ztanczos ztanczos merged commit cd6f50b into morganstanley:main Oct 10, 2023
2 of 4 checks passed
@ztanczos ztanczos deleted the ModuleLoader.Abstractions branch February 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants