Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-loader) - Fixed ModuleLoader behavior with multiple modulecatalogs #606

Merged

fix(ADR-014) - Add ADR about multiple ModuleCatalogs

fa881f3
Select commit
Loading
Failed to load commit list.
Merged

fix(module-loader) - Fixed ModuleLoader behavior with multiple modulecatalogs #606

fix(ADR-014) - Add ADR about multiple ModuleCatalogs
fa881f3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 16, 2024 in 0s

74.34% (-0.03%) compared to 71a5257

View this Pull Request on Codecov

74.34% (-0.03%) compared to 71a5257

Details

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 74.34%. Comparing base (71a5257) to head (fa881f3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   74.36%   74.34%   -0.03%     
==========================================
  Files         238      241       +3     
  Lines        7358     7398      +40     
  Branches      872      818      -54     
==========================================
+ Hits         5472     5500      +28     
- Misses       1693     1706      +13     
+ Partials      193      192       -1     
Files Coverage Δ
...duleLoader.Abstractions/ModuleNotFoundException.cs 100.00% <100.00%> (ø)
...rganStanley.ComposeUI.ModuleLoader/ModuleLoader.cs 88.00% <100.00%> (-4.00%) ⬇️
...mposeUI.ModuleLoader/Runners/NativeModuleRunner.cs 48.48% <0.00%> (ø)
...y.ComposeUI.ModuleLoader/AggregateModuleCatalog.cs 86.66% <86.66%> (ø)
...ModuleLoader.Abstractions/ModuleLoaderException.cs 25.00% <25.00%> (ø)

... and 5 files with indirect coverage changes