Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry tests sometimes fail #146

Closed
bingenito opened this issue Apr 17, 2018 · 0 comments
Closed

Registry tests sometimes fail #146

bingenito opened this issue Apr 17, 2018 · 0 comments
Assignees
@bingenito
Labels
bug test-run-core

Comments

@bingenito
Copy link
Member

Due to parallel test execution the ordering of the tests can sometimes cause failure because the container registry was never being cleared between tests.
@bingenito bingenito self-assigned this Apr 17, 2018
bingenito referenced this issue in bingenito/desktopJS Apr 17, 2018
@bingenito
Fix failing registry tests
53141c5 
registry:
- Add clearRegistry to remove all container registrations
- Change internal list of containerRegistrations to a Map

registry.spec:
- Add teardown after each test to clear the registry so side effects of registrations from other tests can not impact subsequent tests

Fixes #146
@bingenito bingenito mentioned this issue Apr 17, 2018
Merged
bingenito added a commit that referenced this issue Apr 19, 2018
@bingenito
Fix failing registry tests (#147)
da2b4fd 
registry:
- Add clearRegistry to remove all container registrations
- Change internal list of containerRegistrations to a Map

registry.spec:
- Add teardown after each test to clear the registry so side effects of registrations from other tests can not impact subsequent tests

Fixes #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bingenito bingenito

Labels
bug test-run-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bingenito