Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing registry tests #147

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix failing registry tests #147

merged 1 commit into from
Apr 19, 2018

Conversation

bingenito
Copy link
Member

registry:

  • Add clearRegistry to remove all container registrations
  • Change internal list of containerRegistrations to a Map

registry.spec:

  • Add teardown after each test to clear the registry so side effects of registrations from other tests can not impact subsequent tests

Fixes #146

@bingenito
Fix failing registry tests
53141c5 
registry:
- Add clearRegistry to remove all container registrations
- Change internal list of containerRegistrations to a Map

registry.spec:
- Add teardown after each test to clear the registry so side effects of registrations from other tests can not impact subsequent tests

Fixes #146
@bingenito bingenito requested a review from a team April 17, 2018 15:30
@bingenito bingenito merged commit da2b4fd into morganstanley:master Apr 19, 2018
@bingenito bingenito deleted the ISSUE-146 branch May 11, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmulovics psmulovics psmulovics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bingenito @psmulovics