Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] README incomplete? #242

Closed
djasnowski opened this issue May 15, 2019 · 3 comments · Fixed by #244
Closed

[Issue] README incomplete? #242

djasnowski opened this issue May 15, 2019 · 3 comments · Fixed by #244
Assignees

Comments

@djasnowski
Copy link

It seems the readme is not providing all sufficient details to start the desktopJS. For starts, npm run server no longer exists. I cannot seem to find it. Is this replaced by npm run start?

And when I install desktopJS and do npm install, and I go tolocalhost:8000, I get the following errors on Chrome:

GET http://localhost:8000/desktop.js net::ERR_ABORTED 404 (Not Found)
localhost/:10 GET http://localhost:8000/desktopjs-electron.js net::ERR_ABORTED 404 (Not Found)
localhost/:9 GET http://localhost:8000/desktopjs-openfin.js net::ERR_ABORTED 404 (Not Found)
localhost/:10 GET http://localhost:8000/desktopjs-electron.js net::ERR_ABORTED 404 (Not Found)
app.js:49 Uncaught ReferenceError: desktopJS is not defined
    at app.js:49

I am on MacOS Mojave if that makes a difference. (Doubt it.) Or maybe I'm misreading the documentation to get this up and running.

@bingenito bingenito self-assigned this May 15, 2019
@bingenito
Copy link
Member

This goes back to the lerna/monorepo refactor #199 and not updating the readme appropriately. The start/server thing took me a bit to work out as I remember it being in a PR #215, but we had issues with squashing there and it change was missed in the updated PR #221

The big missing piece is having to run (or get it to run post install npm run bootstrap for lerna), then npm run build, then npm start.

@djasnowski
Copy link
Author

Got it. Thanks for the update. Was able to get it working.

@bingenito
Copy link
Member

@naknode Thanks for taking the time to confirm the steps. I'm updating the readme in #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants