Replace gulp-webserver with gulp-connect

[djasnowski]

This adheres issue #195 and successfully replaces said NPM package (which had 2 bad vulns). When I ran npm audit, it had no more security concerns.

➜  ~/code/oss/desktopJS git:(master) npm audit

                       === npm audit security report ===

found 0 vulnerabilities
 in 45568 scanned packages

---

Where can I find the Contributor License Agreement? Would I just talk to the email ([email protected]) asking for it?

[codecov]

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          16       16           
  Lines        1479     1479           
  Branches      249      249           
=======================================
  Hits         1382     1382           
  Misses         97       97

[bingenito]

Thanks @naknode , I'll reply back on your mail about the CLA.

[bingenito]

Excellent. I changed/broke that on the monorepo refactor

[djasnowski]

Thanks @naknode , I'll reply back on your mail about the CLA.

Great! Can't wait to start contributing to Morgan Stanley and this project!

[djasnowski]

DCO has been added and signed.

[bingenito]

@naknode As it is required to indicate on each commit that it is covered by , I'll need updated commit messages. You can squash down to one commit if that is easier.

[djasnowski]

Would you mind showing me how to squash those commits? I'm trying to rebase and I thought I could do, but git rebase is proving to be more tricky than I thought. #220 (comment) is where I failed, too. Thank you.

[bingenito]

@naknode Does this help - https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git ?

[djasnowski]

@bingenito Believe me, I tried. And tried. Git is a fickle thing. Maybe you can see #220 and see if that is applicable to be merged?

[bingenito]

I need the dco on your side on each commit message to cover the submission. I think my merge of my PR in the middle is making this harder. When all else fails I usually just create a new PR.

[djasnowski]

Closing.